Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 29, 2024

PR Checklist

Overview

Updates the regular expression to allow any amount of spaces between the // and the rest of the type. Also updates the payload to .trim().

Similar in implementation to microsoft/DefinitelyTyped-tools#1011, so:

Co-authored-by: @jakebailey

@codecov
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.49%. Comparing base (e7ae213) to head (f2e0afb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
+ Coverage   98.48%   98.49%   +0.01%     
==========================================
  Files          28       28              
  Lines        1515     1533      +18     
  Branches      127      128       +1     
==========================================
+ Hits         1492     1510      +18     
  Misses         23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit b8e3014 into main Nov 29, 2024
20 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the spacing-forgiveness branch November 29, 2024 23:56
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @jakebailey for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @jakebailey! 🎉

@github-actions
Copy link

🎉 This is included in version v0.6.2 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this pull request Nov 30, 2024
Adds @jakebailey as a contributor for code.

This was requested by JoshuaKGoldberg [in this
comment](#645 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: Assertions are sensitive to amount of whitespace

2 participants