Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed issue #104 #105

Merged
merged 5 commits into from
Apr 28, 2021
Merged

fixed issue #104 #105

merged 5 commits into from
Apr 28, 2021

Conversation

AllWorkNoPlay-95
Copy link
Contributor

@AllWorkNoPlay-95 AllWorkNoPlay-95 commented Apr 27, 2021 •
edited
Loading

Fixes #104

Proposed Changes

  • A simple space on line 474 and 512 of 'off-canvas-sidebars.js' to fix the concatenation error in the addClass and removeClass methods.
  • Regenerated minification file.

@AllWorkNoPlay-95 AllWorkNoPlay-95 mentioned this pull request Apr 27, 2021
Closed
@AllWorkNoPlay-95
Copy link
Contributor Author

UPDATE: i found the same error in the removeClass function on line 512 of 'off-canvas-sidebars.js', i applied the same fix.

@JoryHogeveen JoryHogeveen changed the base branch from master to dev April 28, 2021 18:36
@JoryHogeveen JoryHogeveen added this to the 0.5.8 milestone Apr 28, 2021
@JoryHogeveen JoryHogeveen self-requested a review April 28, 2021 18:39
@JoryHogeveen
Copy link
Owner

@AllWorkNoPlay-95 Good find! Thanks for your PR!!

@JoryHogeveen JoryHogeveen merged commit d902ecf into JoryHogeveen:dev Apr 28, 2021
@JoryHogeveen JoryHogeveen modified the milestones: 0.5.8, 0.5.7.1 Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoryHogeveen JoryHogeveen JoryHogeveen approved these changes

Assignees

@AllWorkNoPlay-95 AllWorkNoPlay-95

Labels
bug
Projects
None yet
Milestone
0.5.7.1
Development

Successfully merging this pull request may close these issues.

0.5.7 - Concatentation breaking class names.
2 participants
@AllWorkNoPlay-95 @JoryHogeveen