Repository navigation
Commit 04e2fa4
committed
scuba: Fix make_vol_opt trailing colon bug
When make_vol_opt() was called with options=[], it would return a volume
spec which erroneously contained a trailing colon.
Also, this removes the unnecessary flexibility of passing a single
option string (as opposed to a sequence of option strings). This wasn't
intended by the type signature for options, but unforunately a 'str'
is a 'Sequence[str]'. See python/mypy#11001.
This fixes #215.1 parent c6f3e62 commit 04e2fa4
2 files changed
Lines changed: 4 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
141 | | - | |
142 | | - | |
| 140 | + | |
| 141 | + | |
143 | 142 | | |
144 | 143 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
108 | 108 | | |
109 | 109 | | |
110 | 110 | | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
| 111 | + | |
| 112 | + | |
116 | 113 | | |
117 | 114 | | |
118 | 115 | | |
| |||
0 commit comments