|
| 1 | +import { describe, it, before, after, beforeEach } from "node:test"; |
| 2 | +import assert from "node:assert/strict"; |
| 3 | +import fs from "node:fs"; |
| 4 | +import os from "node:os"; |
| 5 | +import path from "node:path"; |
| 6 | +import { |
| 7 | + markDeadPidJobFailed, |
| 8 | + reconcileIfDead, |
| 9 | + reconcileAllJobs, |
| 10 | + buildStatusSnapshot, |
| 11 | +} from "../plugins/opencode/scripts/lib/job-control.mjs"; |
| 12 | +import { upsertJob, loadState } from "../plugins/opencode/scripts/lib/state.mjs"; |
| 13 | +import { isProcessAlive } from "../plugins/opencode/scripts/lib/process.mjs"; |
| 14 | + |
| 15 | +// PID 999999 is virtually guaranteed to be dead on macOS/Linux (well above |
| 16 | +// pid_max for typical configurations and any short-lived workload). |
| 17 | +const DEAD_PID = 999_999; |
| 18 | + |
| 19 | +describe("isProcessAlive", () => { |
| 20 | + it("returns false for null/undefined/invalid pids", () => { |
| 21 | + assert.equal(isProcessAlive(null), false); |
| 22 | + assert.equal(isProcessAlive(undefined), false); |
| 23 | + assert.equal(isProcessAlive(0), false); |
| 24 | + assert.equal(isProcessAlive(-1), false); |
| 25 | + assert.equal(isProcessAlive(NaN), false); |
| 26 | + }); |
| 27 | + |
| 28 | + it("returns true for the current process", () => { |
| 29 | + assert.equal(isProcessAlive(process.pid), true); |
| 30 | + }); |
| 31 | + |
| 32 | + it("returns false for a clearly dead pid", () => { |
| 33 | + assert.equal(isProcessAlive(DEAD_PID), false); |
| 34 | + }); |
| 35 | +}); |
| 36 | + |
| 37 | +describe("markDeadPidJobFailed", () => { |
| 38 | + let workspace; |
| 39 | + let previousPluginData; |
| 40 | + |
| 41 | + before(() => { |
| 42 | + workspace = fs.mkdtempSync(path.join(os.tmpdir(), "opencode-deadpid-")); |
| 43 | + previousPluginData = process.env.CLAUDE_PLUGIN_DATA; |
| 44 | + process.env.CLAUDE_PLUGIN_DATA = fs.mkdtempSync( |
| 45 | + path.join(os.tmpdir(), "opencode-deadpid-data-") |
| 46 | + ); |
| 47 | + }); |
| 48 | + |
| 49 | + after(() => { |
| 50 | + if (previousPluginData == null) { |
| 51 | + delete process.env.CLAUDE_PLUGIN_DATA; |
| 52 | + } else { |
| 53 | + process.env.CLAUDE_PLUGIN_DATA = previousPluginData; |
| 54 | + } |
| 55 | + }); |
| 56 | + |
| 57 | + beforeEach(() => { |
| 58 | + // Wipe state before each test. |
| 59 | + const state = loadState(workspace); |
| 60 | + state.jobs = []; |
| 61 | + upsertJob(workspace, { id: "__seed__", status: "completed" }); |
| 62 | + const after = loadState(workspace); |
| 63 | + after.jobs = []; |
| 64 | + for (const j of after.jobs) {} |
| 65 | + }); |
| 66 | + |
| 67 | + it("rewrites a running job with a dead pid to failed", () => { |
| 68 | + upsertJob(workspace, { |
| 69 | + id: "task-1", |
| 70 | + status: "running", |
| 71 | + type: "task", |
| 72 | + pid: DEAD_PID, |
| 73 | + }); |
| 74 | + const written = markDeadPidJobFailed(workspace, "task-1", DEAD_PID); |
| 75 | + assert.equal(written, true); |
| 76 | + |
| 77 | + const stored = loadState(workspace).jobs.find((j) => j.id === "task-1"); |
| 78 | + assert.equal(stored.status, "failed"); |
| 79 | + assert.equal(stored.phase, "failed"); |
| 80 | + assert.equal(stored.pid, null); |
| 81 | + assert.match(stored.errorMessage, new RegExp(`PID ${DEAD_PID}`)); |
| 82 | + }); |
| 83 | + |
| 84 | + it("refuses to downgrade a terminal state", () => { |
| 85 | + upsertJob(workspace, { |
| 86 | + id: "task-2", |
| 87 | + status: "completed", |
| 88 | + type: "task", |
| 89 | + pid: DEAD_PID, |
| 90 | + }); |
| 91 | + const written = markDeadPidJobFailed(workspace, "task-2", DEAD_PID); |
| 92 | + assert.equal(written, false); |
| 93 | + |
| 94 | + const stored = loadState(workspace).jobs.find((j) => j.id === "task-2"); |
| 95 | + assert.equal(stored.status, "completed"); |
| 96 | + }); |
| 97 | + |
| 98 | + it("refuses when the pid has changed since probe", () => { |
| 99 | + upsertJob(workspace, { |
| 100 | + id: "task-3", |
| 101 | + status: "running", |
| 102 | + type: "task", |
| 103 | + pid: 12345, |
| 104 | + }); |
| 105 | + // Probe observed DEAD_PID, but latest pid is 12345 → refuse. |
| 106 | + const written = markDeadPidJobFailed(workspace, "task-3", DEAD_PID); |
| 107 | + assert.equal(written, false); |
| 108 | + |
| 109 | + const stored = loadState(workspace).jobs.find((j) => j.id === "task-3"); |
| 110 | + assert.equal(stored.status, "running"); |
| 111 | + }); |
| 112 | +}); |
| 113 | + |
| 114 | +describe("reconcileIfDead", () => { |
| 115 | + let workspace; |
| 116 | + let previousPluginData; |
| 117 | + |
| 118 | + before(() => { |
| 119 | + workspace = fs.mkdtempSync(path.join(os.tmpdir(), "opencode-reconcile-")); |
| 120 | + previousPluginData = process.env.CLAUDE_PLUGIN_DATA; |
| 121 | + process.env.CLAUDE_PLUGIN_DATA = fs.mkdtempSync( |
| 122 | + path.join(os.tmpdir(), "opencode-reconcile-data-") |
| 123 | + ); |
| 124 | + }); |
| 125 | + |
| 126 | + after(() => { |
| 127 | + if (previousPluginData == null) { |
| 128 | + delete process.env.CLAUDE_PLUGIN_DATA; |
| 129 | + } else { |
| 130 | + process.env.CLAUDE_PLUGIN_DATA = previousPluginData; |
| 131 | + } |
| 132 | + }); |
| 133 | + |
| 134 | + it("leaves a running job with a live pid alone", () => { |
| 135 | + upsertJob(workspace, { |
| 136 | + id: "live-1", |
| 137 | + status: "running", |
| 138 | + type: "task", |
| 139 | + pid: process.pid, |
| 140 | + }); |
| 141 | + const result = reconcileIfDead(workspace, { |
| 142 | + id: "live-1", |
| 143 | + status: "running", |
| 144 | + pid: process.pid, |
| 145 | + }); |
| 146 | + assert.equal(result.status, "running"); |
| 147 | + }); |
| 148 | + |
| 149 | + it("reconciles a running job with a dead pid to failed", () => { |
| 150 | + upsertJob(workspace, { |
| 151 | + id: "dead-1", |
| 152 | + status: "running", |
| 153 | + type: "task", |
| 154 | + pid: DEAD_PID, |
| 155 | + }); |
| 156 | + const result = reconcileIfDead(workspace, { |
| 157 | + id: "dead-1", |
| 158 | + status: "running", |
| 159 | + pid: DEAD_PID, |
| 160 | + }); |
| 161 | + assert.equal(result.status, "failed"); |
| 162 | + assert.equal(result.phase, "failed"); |
| 163 | + }); |
| 164 | + |
| 165 | + it("leaves running jobs with no pid alone", () => { |
| 166 | + const job = { id: "nopid", status: "running", pid: null }; |
| 167 | + const result = reconcileIfDead(workspace, job); |
| 168 | + assert.equal(result, job); |
| 169 | + }); |
| 170 | + |
| 171 | + it("leaves terminal-state jobs alone", () => { |
| 172 | + const job = { id: "done", status: "completed", pid: DEAD_PID }; |
| 173 | + const result = reconcileIfDead(workspace, job); |
| 174 | + assert.equal(result, job); |
| 175 | + }); |
| 176 | +}); |
| 177 | + |
| 178 | +describe("buildStatusSnapshot reconciles dead pids inline", () => { |
| 179 | + let workspace; |
| 180 | + let previousPluginData; |
| 181 | + |
| 182 | + before(() => { |
| 183 | + workspace = fs.mkdtempSync(path.join(os.tmpdir(), "opencode-snapshot-")); |
| 184 | + previousPluginData = process.env.CLAUDE_PLUGIN_DATA; |
| 185 | + process.env.CLAUDE_PLUGIN_DATA = fs.mkdtempSync( |
| 186 | + path.join(os.tmpdir(), "opencode-snapshot-data-") |
| 187 | + ); |
| 188 | + }); |
| 189 | + |
| 190 | + after(() => { |
| 191 | + if (previousPluginData == null) { |
| 192 | + delete process.env.CLAUDE_PLUGIN_DATA; |
| 193 | + } else { |
| 194 | + process.env.CLAUDE_PLUGIN_DATA = previousPluginData; |
| 195 | + } |
| 196 | + }); |
| 197 | + |
| 198 | + it("surfaces a dead-pid running job as failed in one read", () => { |
| 199 | + const now = new Date().toISOString(); |
| 200 | + const jobs = [ |
| 201 | + { |
| 202 | + id: "zombie", |
| 203 | + status: "running", |
| 204 | + type: "task", |
| 205 | + pid: DEAD_PID, |
| 206 | + createdAt: now, |
| 207 | + updatedAt: now, |
| 208 | + }, |
| 209 | + ]; |
| 210 | + upsertJob(workspace, jobs[0]); |
| 211 | + |
| 212 | + const snapshot = buildStatusSnapshot(jobs, workspace); |
| 213 | + assert.equal(snapshot.running.length, 0); |
| 214 | + assert.ok(snapshot.latestFinished); |
| 215 | + assert.equal(snapshot.latestFinished.id, "zombie"); |
| 216 | + assert.equal(snapshot.latestFinished.status, "failed"); |
| 217 | + }); |
| 218 | +}); |
| 219 | + |
| 220 | +describe("reconcileAllJobs", () => { |
| 221 | + it("returns input unchanged when empty", () => { |
| 222 | + assert.deepEqual(reconcileAllJobs([], "/tmp"), []); |
| 223 | + assert.equal(reconcileAllJobs(null, "/tmp"), null); |
| 224 | + }); |
| 225 | +}); |
0 commit comments