Narrow Closure::bind $newScope param#1591
Merged
isfedorov merged 1 commit intoJetBrains:masterfrom Dec 1, 2023
mvorisek:narrow_closure_bind_param
Merged
Narrow Closure::bind $newScope param#1591isfedorov merged 1 commit intoJetBrains:masterfrom mvorisek:narrow_closure_bind_param
isfedorov merged 1 commit intoJetBrains:masterfrom
mvorisek:narrow_closure_bind_param
Conversation
isfedorov
requested changes
Nov 30, 2023
Contributor
|
@mvorisek Thank you for the PR! Generally the change completely makes sense except a couple of notes I've added inline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.php.net/manual/en/closure.bind.php
should prevent passing unknown classes together with static analysers