Explain: fix for destructuring declarations

bnorm · Space Team · commit 502e84484e52 · 2026-04-14T16:06:04.000Z
#KT-85103 fixed
diff --git a/plugins/scripting/scripting-compiler/src/org/jetbrains/kotlin/scripting/compiler/plugin/extensions/ScriptingProcessSourcesBeforeCompilingExtension.kt b/plugins/scripting/scripting-compiler/src/org/jetbrains/kotlin/scripting/compiler/plugin/extensions/ScriptingProcessSourcesBeforeCompilingExtension.kt
@@ -177,6 +177,17 @@ class KotlinScriptExpressionExplainTransformer(
                 statement
             }
         }
+        is IrComposite -> {
+            if (statement.origin == IrStatementOrigin.DESTRUCTURING_DECLARATION) {
+                // Only the first statement of a destructing declaration should be transformed. Otherwise, the backend got confused.
+                // The first statement is the assignment to the destructuring var anyway, so we don't lose information here.
+                statement.statements[0] = explainStatement(statement.statements[0], builder, explanationsProp, declaration, "")
+                statement
+            } else {
+                statement.statements.transformInPlace { explainStatement(it, builder, explanationsProp, declaration, "") }
+                statement
+            }
+        }
         is IrExpression -> {
             if (statement is IrTypeOperatorCall && statement.operator == IrTypeOperator.IMPLICIT_COERCION_TO_UNIT) {
                 statement.argument = explainWithFallBack(statement.argument, declaration, statementName, builder, explanationsProp)
diff --git a/plugins/scripting/scripting-compiler/testData/compiler/explain/destructuringDecls.explain b/plugins/scripting/scripting-compiler/testData/compiler/explain/destructuringDecls.explain
@@ -0,0 +1,5 @@
+<destruct>(17, 25) = (1, 2)
+(26, 29) = 1
+(30, 33) = 2
+<destruct>(49, 57) = (3, 4)
+$$result(58, 61) = 4
diff --git a/plugins/scripting/scripting-compiler/tests/org/jetbrains/kotlin/scripting/compiler/plugin/ScriptingWithExplanationCompilerTest.kt b/plugins/scripting/scripting-compiler/tests/org/jetbrains/kotlin/scripting/compiler/plugin/ScriptingWithExplanationCompilerTest.kt
@@ -126,7 +126,7 @@ class ScriptingWithExplanationCompilerTest {
 
     @Test // KT-85103
     fun testScriptExplainDestructuringDeclarations() {
-        runScriptAndValidateExplain("$TEST_DATA_DIR/destructuringDecls.kts", expectedExitCode = ExitCode.COMPILATION_ERROR)
+        runScriptAndValidateExplain("$TEST_DATA_DIR/destructuringDecls.kts", expectedExitCode = ExitCode.OK)
     }
 
     @Test // KT-85105

Original file line number	Diff line number	Diff line change
`@@ -126,7 +126,7 @@ class ScriptingWithExplanationCompilerTest {`
`126`	`126`
`127`	`127`	`@Test // KT-85103`
`128`	`128`	`fun testScriptExplainDestructuringDeclarations() {`
`129`		`- runScriptAndValidateExplain("$TEST_DATA_DIR/destructuringDecls.kts", expectedExitCode = ExitCode.COMPILATION_ERROR)`
	`129`	`+ runScriptAndValidateExplain("$TEST_DATA_DIR/destructuringDecls.kts", expectedExitCode = ExitCode.OK)`
`130`	`130`	`}`
`131`	`131`
`132`	`132`	`@Test // KT-85105`