Conversation
Fixed IllegalStateException "Only Sp can convert to Px" when using Bullets with Em units (e.g., Bullet.DefaultIndentation) in Compose desktop. The textIndent conversion now uses toPx(density, fontSize) which properly handles both Em and Sp units, matching the pattern used for placeholder conversion elsewhere in the file. Added regression test to verify Bullets with Em units work correctly.
kropp
force-pushed
the
CMP-9453-fix-bullet-em-units
branch
from
0b6a5d1 to
061f3b2
Compare
kropp
force-pushed
the
CMP-9453-fix-bullet-em-units
branch
from
061f3b2 to
8a69021
Compare
MatkovIvan
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the textIndent conversion to use the overloaded toPx(density, fontSize) extension function that properly handles both Em and Sp units. This matches the pattern already used for placeholder conversion in the same file (lines 566-572).
Fixes CMP-9453
Testing
SkikoParagraphTest.bullet_withEmUnits_shouldNotCrash
Release Notes
Fixes - Multiple Platforms
BulletswithEmunits