Rename WebElementView to HtmlElementView and migrate all usages#2636
Rename WebElementView to HtmlElementView and migrate all usages#2636eymar merged 6 commits intoJetBrains:jb-mainfrom
Conversation
|
Could you please run |
|
done |
|
I see a lot of unrelated changes in the new api dump (for example for material3). I'll investigate. |
|
I'm not sure why it generate such api dump in your case. (Do you have unstaged changes? I doubt, but that would exaplain it) When I tried to update the dump in your branch it resulted only in one change: I think we can eliminate that change by keeping If you return |
compose/ui/ui/src/webMain/kotlin/androidx/compose/ui/viewinterop/InteropView.web.kt
Show resolved
Hide resolved
This reverts commit 3bb9080.
none that affect Material 3 sources or foundation Locale. I just did what you suggested since I cannot seem to make it work without it or not updating api dump. If you could do it from your side for it to work would be better but for now this is what I can do |
Schahen
left a comment
There was a problem hiding this comment.
Totally makes sense, strictly speaking we can deal in this HtmlViewElement with non-HTML DOM entities as well (first SVG comes to mind) but that's nit-picking already
Renaming WebElementView to HtmlElementView to better reflect the type of layout we are interoping with. Since all Interop elements in Web are bounded to HtmlElement from the dom apis, it makes sense to update the name to better reflect the purpose
Fixes https://youtrack.jetbrains.com/issue/CMP-9313
Release Notes
Migration Notes - Web
WebElementViewtoHtmlElementViewto better reflect its HTML-specific purpose