Skip to content

Comments

Fix saveable state restoration on non-android targets#2615

Merged
terrakok merged 2 commits intojb-mainfrom
CMP-9375
Dec 3, 2025
Merged

Fix saveable state restoration on non-android targets#2615
terrakok merged 2 commits intojb-mainfrom
CMP-9375

Conversation

@terrakok
Copy link
Member

@terrakok terrakok commented Dec 2, 2025

Copy changes from https://android-review.googlesource.com/c/platform/frameworks/support/+/3852539

Fixes CMP-9375 SavedState is always null on non-android when restored

Release Notes

Fixes - Lifecycle

  • Fix saveable state restoration on non-android targets

@terrakok terrakok requested a review from MatkovIvan December 2, 2025 16:16
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we already have not-upstreamed diff in this place, so changing it should be fine.

In any case:

  1. it's not "(prerelize fix)"
  2. it's better to have some unit test for this problem

@terrakok
Copy link
Member Author

terrakok commented Dec 3, 2025

Added all SavedStateHandleSaverTest adopted to a desktop

@terrakok terrakok requested a review from MatkovIvan December 3, 2025 13:55
@terrakok terrakok merged commit 1c691cc into jb-main Dec 3, 2025
16 checks passed
@terrakok terrakok deleted the CMP-9375 branch December 3, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants