Make WebElementView API accessible in webMain source set#2614
Merged
Conversation
eymar
changed the title
eymar
commented
Dec 2, 2025
| */ | ||
|
|
||
| package androidx.compose.ui.window | ||
| package androidx.compose.ui.platform |
Member
Author
There was a problem hiding this comment.
It's not a rename/move of a file. GitHub is just confused.
eymar
commented
Dec 2, 2025
| } | ||
|
|
||
| class JsPlatformClipboard : Clipboard { | ||
| private class JsPlatformClipboard : Clipboard { |
eymar
commented
Dec 2, 2025
| } | ||
|
|
||
| class WasmPlatformClipboard : Clipboard { | ||
| private class WasmPlatformClipboard : Clipboard { |
MatkovIvan
reviewed
Dec 3, 2025
Member
MatkovIvan
left a comment
MatkovIvan
left a comment
There was a problem hiding this comment.
Such changes require two approvals
compose/ui/ui/src/webMain/kotlin/androidx/compose/ui/platform/BackingDomInput.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/webMain/kotlin/androidx/compose/ui/window/ComposeWindow.web.kt
Show resolved
Hide resolved
Schahen
approved these changes
Dec 3, 2025
Collaborator
|
Removed myself from review, as Shagen approved, and Ivan review was requested |
MatkovIvan
approved these changes
Dec 3, 2025
pjBooms
added a commit
to JetBrains/compose-multiplatform
that referenced
this pull request
Dec 18, 2025
[#2614](JetBrains/compose-multiplatform-core#2614) bumps LV to 2.2 for all non-android platforms so let's update explicit check as well. Fixes [CMP-9282](https://youtrack.jetbrains.com/issue/CMP-9282/Minimal-Kotlin-version-requirements) ## Release Notes N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change
WebElementViewcan be used only separately in jsMain and in wasmJsMain.Fixes https://youtrack.jetbrains.com/issue/CMP-9146
webMainTesting
Existing tests
Release Notes
Fixes - Web
WebElementViewis now available inwebMainsource setCanvasBasedWindowhas been deletedMigration Notes - Multiple Platforms
2.2. The projects depending on Compose Multiplatform need to use the same version or newer.