Skip to content

Comments

Add support for configurable end edge gesture behaviors in UIKit navigation logic#2519

Merged
terrakok merged 4 commits intojb-mainfrom
CMP-7180
Oct 24, 2025
Merged

Add support for configurable end edge gesture behaviors in UIKit navigation logic#2519
terrakok merged 4 commits intojb-mainfrom
CMP-7180

Conversation

@terrakok
Copy link
Member

@terrakok terrakok commented Oct 23, 2025 •
edited
Loading

Added support for configurable end edge gesture behaviors in UIKit navigation logic.

fun MainViewController(): UIViewController = ComposeUIViewController(
    configure = {
        endEdgePanGestureBehavior = EndEdgePanGestureBehavior.Disabled //default
    }
) {
    App()
}

Fixes CMP-9004

End edge gesture is disabled by default:

1.mp4

There is EndEdgeGestureBehavior.Back option:

2.mp4

And there is EndEdgeGestureBehavior.Forward.

Release Notes

Features - Navigation

  • Add a new configuration option in ComposeUIViewController to set end-edge gestures behavior.

terrakok
terrakok commented Oct 24, 2025
View reviewed changes
...src/uikitMain/kotlin/androidx/compose/ui/uikit/ComposeUIViewControllerConfiguration.uikit.kt Outdated
* Default value is [EndEdgeGestureBehavior.Disabled].
*/
@ExperimentalComposeUiApi
var endEdgeGestureBehavior: EndEdgeGestureBehavior = EndEdgeGestureBehavior.Disabled
Copy link
Member Author

@terrakok terrakok Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the compose it is called start/end. (e.g. paddings)

ASalavei
ASalavei reviewed Oct 24, 2025
View reviewed changes
...src/uikitMain/kotlin/androidx/compose/ui/uikit/ComposeUIViewControllerConfiguration.uikit.kt Outdated
* Default value is [EndEdgeGestureBehavior.Disabled].
*/
@ExperimentalComposeUiApi
var endEdgeGestureBehavior: EndEdgeGestureBehavior = EndEdgeGestureBehavior.Disabled
Copy link

@ASalavei ASalavei Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EndEdgeGestureBehavior -> EndEdgePanGestureBehavior

ASalavei
ASalavei reviewed Oct 24, 2025
View reviewed changes
...src/uikitMain/kotlin/androidx/compose/ui/uikit/ComposeUIViewControllerConfiguration.uikit.kt Outdated
var parallelRendering: Boolean = false

/**
* Determines how the end edge gestures will be handled.
Copy link

@ASalavei ASalavei Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"edge gestures" -> "edge pan gestures".
Please also fix in other places.

MatkovIvan
MatkovIvan reviewed Oct 24, 2025
View reviewed changes
Copy link
Member

@MatkovIvan MatkovIvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New public API LGTM.

For implementation - please wait review from iOS folks.
Also, I'd love to see a test for that. Our infra should be ready for such thing. (right? cc @ASalavei)

@terrakok terrakok merged commit 72b4dda into jb-main Oct 24, 2025
40 of 42 checks passed
@terrakok terrakok deleted the CMP-7180 branch October 24, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MatkovIvan MatkovIvan MatkovIvan approved these changes

@ASalavei ASalavei ASalavei approved these changes

Assignees

No one assigned

Labels

changes in API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@terrakok @MatkovIvan @ASalavei