Register mouse wheel listeners on the container rather than the compose content#2486
Merged
Register mouse wheel listeners on the container rather than the compose content#2486
Conversation
4c825c6 to
b3246fd
Compare
b3246fd to
278e327
Compare
d50c500 to
ef7982d
Compare
278e327 to
63456d7
Compare
…pose content and interop views) to receive them even when they occur over an interop view.
…fy the expected buttons and modifiers.
63456d7 to
f97407a
Compare
MatkovIvan
reviewed
Oct 28, 2025
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.desktop.kt
Outdated
Show resolved
Hide resolved
…eFromMouseEvents`
MatkovIvan
approved these changes
Oct 28, 2025
compose/ui/ui/src/desktopTest/kotlin/androidx/compose/ui/awt/SwingPanelTest.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The container is the common parent of the compose content (skia layer) and the interop views. This is needed to receive them even when they occur over an interop view.
Fixes https://youtrack.jetbrains.com/issue/CMP-1062/SwingPanel-breaks-vertical-scrolling
In
WindowInputEventTest.receive buttons and modifiersI changed the check from exactly matching the keyboard modifiers to verifying that the expected modifiers are on. Because of a problem in AWT.Testing
Tested manually and added a unit tests.
This should be tested by QA
Release Notes
Fixes - Desktop
SwingPanelblocking mouse wheel scroll events from going to its parent.