Provide access to semanticsOwners in desktop entry points#2358
Merged
Provide access to semanticsOwners in desktop entry points#2358
semanticsOwners in desktop entry points#2358Conversation
MatkovIvan
reviewed
Aug 27, 2025
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeContainer.desktop.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposeWindowPanel.desktop.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.desktop.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/skikoMain/kotlin/androidx/compose/ui/ImageComposeScene.skiko.kt
Outdated
Show resolved
Hide resolved
daef224 to
e9c6fa0
Compare
MatkovIvan
reviewed
Aug 27, 2025
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposePanel.desktop.kt
Show resolved
Hide resolved
…` and `ImageComposeScene`
e9c6fa0 to
e3eb4c0
Compare
MatkovIvan
approved these changes
Aug 27, 2025
Author
|
Needs another approve from @igordmn |
igordmn
reviewed
Aug 27, 2025
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/ComposePanel.desktop.kt
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/scene/ComposeSceneMediator.desktop.kt
Outdated
Show resolved
Hide resolved
igordmn
approved these changes
Aug 28, 2025
Author
|
Merging without the snapshot state tests; will fix them later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide access to
semanticsOwnersinComposeWindow,ComposePanelandImageComposeScene.This is useful to allow external tools to examine the structure of the UI.
Fixes https://youtrack.jetbrains.com/issue/CMP-8824/Expose-semantics-tree-in-ComposePanel-and-ComposeWindow
Example usage
Details
Testing
Tested manually and added unit tests.
Release Notes
Features - Desktop
ComposeWindow,ComposePanelandImageComposeScene) now exposeval semanticsOwners: Collection<SemanticsOwner>.