Skip to content

Comments

Add API to configure inputView and inputAccessoryView with PlatformImeOptions#2350

Merged
svastven merged 12 commits intojb-mainfrom
svastven/input-view-api
Aug 26, 2025
Merged

Add API to configure inputView and inputAccessoryView with PlatformImeOptions#2350
svastven merged 12 commits intojb-mainfrom
svastven/input-view-api

Conversation

@svastven
Copy link

@svastven svastven commented Aug 25, 2025

  • Adds API to configure UIResponder.inputView with PlatformImeOptions
  • Adds API to configure UIResponder.inputAccessoryView with PlatformImeOptions
  • Creates ImeOptionsTest and add tests for input traits and inputView

Fixes

  • CMP-7883 Provide API to configure inputView
  • CMP-8810 Provide API to configure inputAccessoryView
  • CMP-8244 iOS tests for native IME options API

Testing

  • Adds tests for providing custom inputView
  • Adds tests for providing custom inputAccessoryView
  • Adds example screen with custom inputView and inputAccessoryView to the demo app at iOS-specific-features/iOS Platform IME Options/Input View

Release Notes

Features - iOS

  • Add API to configure UIResponder.inputView with PlatformImeOptions
  • Add API to configure UIResponder.inputAccessoryView with PlatformImeOptions

@svastven svastven changed the title Add API to configure UIResponder.inputView with PlatformImeOptions Add API to configure UIResponder.inputView and UIResponder.inputAccessoryView with PlatformImeOptions Aug 25, 2025
@svastven svastven changed the title Add API to configure UIResponder.inputView and UIResponder.inputAccessoryView with PlatformImeOptions Add API to configure inputView and inputAccessoryView with PlatformImeOptions Aug 25, 2025
Co-authored-by: Andrei Salavei <[email protected]>
@svastven svastven merged commit 379021d into jb-main Aug 26, 2025
10 checks passed
@svastven svastven deleted the svastven/input-view-api branch August 26, 2025 11:06
@igordmn
Copy link
Collaborator

igordmn commented Aug 26, 2025

The PR adds new public API, so we need 2 approvals before merging (we don't have auto-checks)

@mazunin-v-jb, please review the new API, and just write a comment if you approve, or request new changes

@svastven
Copy link
Author

My mistake, I thought that when the PR passes all checks without requiring an API Dump, one review was enough. Thanks for sharing the doc @igordmn, I'll keep it in mind for next time!

@mazunin-v-jb could you please add review to this PR? Thanks

@igordmn
Copy link
Collaborator

igordmn commented Aug 26, 2025

We exclude @ExperimentalComposeUiApi from the dump, but the API itself should be reviewed.

In the future we might dump it into another "Dump for Experimental API" to not miss it.

Copy link

@mazunin-v-jb mazunin-v-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants