Add modalityType parameter to DialogWindow#2300
Conversation
6fd03ea to
58e33cd
Compare
| title: String = "Untitled", | ||
| icon: Painter? = null, | ||
| decoration: WindowDecoration, | ||
| decoration: WindowDecoration = WindowDecoration.SystemDefault, |
There was a problem hiding this comment.
We have it experimental for some time. We need to start stabilize functions which we added earlier, and schedule stabilizing modalityType as well.
Please, create issues for stabilizing decoration/modalityType with appropriate target versions (this doc says we usually should stabilize in the +2 version)
There was a problem hiding this comment.
Created https://youtrack.jetbrains.com/issue/CMP-8730/Remove-experimental-status-from-DialogWindow-and-SwingDialog, but there's no 1.12 target version to set.
There was a problem hiding this comment.
Added new versions with discussion with Kropp
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/window/Dialog.desktop.kt
Show resolved
Hide resolved
MatkovIvan
left a comment
There was a problem hiding this comment.
Please re-gen once again API dump
Add
modalityTypeparameter toDialogWindowTesting
Tested manually with
This could be tested by QA
Release Notes
Features - Desktop
modalityTypeparameter toDialogWindow().