Conversation
| implementation(project(":lifecycle:lifecycle-common")) | ||
| implementation(project(":lifecycle:lifecycle-runtime")) |
There was a problem hiding this comment.
It isn't used in Android or commonMain, so we should keep it here
There was a problem hiding this comment.
They are not required in common, as I introduced changes in skikoMain/skikoTest only, so I decided to include dependencies only for these source roots.
There was a problem hiding this comment.
I'd like to see some common API at some point, but it requires changes in AOSP first
compose/ui/ui-test/src/skikoMain/kotlin/androidx/compose/ui/test/ComposeUiTest.skikoMain.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-test/src/skikoMain/kotlin/androidx/compose/ui/test/ComposeUiTest.skikoMain.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-test/src/skikoMain/kotlin/androidx/compose/ui/test/ComposeUiTest.skikoMain.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-test/src/skikoMain/kotlin/androidx/compose/ui/test/ComposeUiTest.skikoMain.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui-test/src/skikoTest/kotlin/LifecycleInTestsTest.kt
Outdated
Show resolved
Hide resolved
kropp
force-pushed
the
kropp/lifecycle-in-tests
branch
from
b7acd5b to
c42d96d
Compare
| lifecycleOwner.lifecycle.handleLifecycleEvent(event) | ||
| } | ||
|
|
||
| private fun ProvideTestCompositionLocals(composable: @Composable () -> Unit): @Composable () -> Unit = { |
There was a problem hiding this comment.
| private fun ProvideTestCompositionLocals(composable: @Composable () -> Unit): @Composable () -> Unit = { | |
| @Composable | |
| private fun ProvideTestCompositionLocals(content: @Composable () -> Unit) { |
| actual fun registerIdlingResource(idlingResource: IdlingResource) | ||
| actual fun unregisterIdlingResource(idlingResource: IdlingResource) | ||
| actual fun setContent(composable: @Composable () -> Unit) | ||
| fun sendLifecycleEvent(event: Lifecycle.Event) |
There was a problem hiding this comment.
KDoc is required for all public APIs
|
Does Android provide LifecycleOwner in tests? |
I don't think so. Delegating the review to m-sasha, as the owner of ui-test |
|
@m-sasha |
|
If Android's ui-test doesn't include lifecycle stuff, I'm thinking maybe we shouldn't either. Can we provide the same functionality from e.g. lifecycle-test? |
|
hi! Are any plans to merge that pull request? and changes needed? |
…2400) Fixes [CMP-7419](https://youtrack.jetbrains.com/issue/CMP-7419) CompositionLocal LocalLifecycleOwner not present on iosSimulatorArm64Test task Replacemed of #1294 with no public API for now. The target here is provide unified default behavior between platforms and unblock navigation tests in `commonTest` without additional workarounds. ## Release Notes ### Features - Multiple Platforms - Provide `LocalLifecycleOwner` inside `runComposeUiTest` by default --------- Co-authored-by: Victor Kropp <[email protected]>
5 participants
Proposed Changes
LifecycleOwnerin tests, provide it inLocalLifecycleOwnerLifecycleinrunComposeUiTestTesting
Test: LifecycleInTestsTest