Skip to content

Comments

CMP-9545: Cache Storage API extra check for protocol (#5516)#5518

Merged
siarb merged 1 commit intorelease/1.10from
ok/cherry-pick-CMP-9545-to-1.10
Jan 20, 2026
Merged

CMP-9545: Cache Storage API extra check for protocol (#5516)#5518
siarb merged 1 commit intorelease/1.10from
ok/cherry-pick-CMP-9545-to-1.10

Conversation

@eymar
Copy link
Member

@eymar eymar commented Jan 20, 2026

Cherry pick from #5516

Fixes
https://youtrack.jetbrains.com/issue/CMP-9545/ComposeResources-on-Web-not-loading-because-Cache-Storage-API-is-not-supported-everywhere

Testing

This should be tested by QA

Release Notes

Fixes - Resources

Fixes an issue where web resources failed to load when calling the Cache Storage API with unsupported protocols (e.g., vscode-webview: in VS Code webviews).

Compose Multiplatform v1.10.0 introduced the use of the Cache Storage
API to avoid repeat http requests for resources on Web
([#5379](#5379)).

In a VsCode Extension Environment, the protocol of a Web View Panel that
gets used is "vscode-webview:". This does not work with the Cache
Storage API and results in an error when trying to load any compose
resources. This PR just ensures the protocol is http/https in order to
use Cache Storage API on Web Target.

Fixes
https://youtrack.jetbrains.com/issue/CMP-9545/ComposeResources-on-Web-not-loading-because-Cache-Storage-API-is-not-supported-everywhere

## Testing
**Describe how you tested your changes (provide a snippet or/and
steps)**
- I ran my vscode extension with the change and without the change

**without**
<img width="1658" height="753" alt="image"
src="https://github.com/user-attachments/assets/367f5a41-4b0b-4262-9d38-3baca1ce0125"
/>

**with**
<img width="1658" height="885" alt="image"
src="https://github.com/user-attachments/assets/b06415df-1388-45c2-a439-21e604fc2e54"
/>

- I ran a regular browserDevelopmentRun to ensure caching still worked
as expected
<img width="1863" height="942" alt="image"
src="https://github.com/user-attachments/assets/54e7dd47-084c-4514-b79b-32f35577dc92"
/>

## Release Notes
### Fixes - Resources
Fixes an issue where web resources failed to load when calling the Cache
Storage API with unsupported protocols (e.g., vscode-webview: in VS Code
webviews).

(cherry picked from commit 89f6aea)
@eymar eymar requested a review from siarb January 20, 2026 14:51
@siarb siarb merged commit 924efbb into release/1.10 Jan 20, 2026
1 check passed
@siarb siarb deleted the ok/cherry-pick-CMP-9545-to-1.10 branch January 20, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants