Add support of important in compose html css dsl#5439
Merged
eymar merged 7 commits intoJetBrains:masterfrom Oct 28, 2025
Merged
Add support of important in compose html css dsl#5439eymar merged 7 commits intoJetBrains:masterfrom
eymar merged 7 commits intoJetBrains:masterfrom
Conversation
Contributor
Author
|
Hello :) mr. @eymar is there any news when this PR will be reviewed? Can't wait to fix some problems here and see this PR in |
eymar
reviewed
Oct 24, 2025
html/core/src/jsMain/kotlin/org/jetbrains/compose/web/css/StyleScope.kt
Outdated
Show resolved
Hide resolved
html/core/src/jsMain/kotlin/org/jetbrains/compose/web/css/StyleScope.kt
Outdated
Show resolved
Hide resolved
html/core/src/jsMain/kotlin/org/jetbrains/compose/web/dom/Base.kt
Outdated
Show resolved
Hide resolved
html/core/src/jsMain/kotlin/org/jetbrains/compose/web/css/StyleScope.kt
Outdated
Show resolved
Hide resolved
…eScope.kt Co-authored-by: Oleksandr Karpovich <[email protected]>
Contributor
Author
|
@eymar thanks for your review :) I have fixed code according to it, could you please check it again? |
eymar
reviewed
Oct 27, 2025
html/core/src/jsMain/kotlin/org/jetbrains/compose/web/css/StyleScope.kt
Outdated
Show resolved
Hide resolved
eymar
reviewed
Oct 28, 2025
Member
eymar
left a comment
eymar
left a comment
There was a problem hiding this comment.
Merged. Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://youtrack.jetbrains.com/issue/CMP-8992
Testing
Add test in
org.jetbrains.compose.web.core.tests.css.StyleSheetTestsRelease Notes
Features - HTML
importantkeyword for CSS properties