Issue 221 - Map java.time.Instant to type stored in UTC#1223
Closed
tnleeuw wants to merge 6 commits intoJetBrains:mainfrom
Closed
Issue 221 - Map java.time.Instant to type stored in UTC#1223tnleeuw wants to merge 6 commits intoJetBrains:mainfrom
java.time.Instant to type stored in UTC#1223tnleeuw wants to merge 6 commits intoJetBrains:mainfrom
Conversation
Author
|
Unit tests failed when I pushed change to remove version-nr update. They passed before that. I will see if I can find out why that is but of course I do not want to merge a change tot the version-nr; perhaps I should rebase on master instead of having branched off of the release 0.31.1 version! |
added 4 commits
May 12, 2021 14:21
…amp with timezone types.
Rebased branch on master.
tnleeuw
force-pushed
the
ISSUE-221-TimestampWithTimezone
branch
from
672b5e2 to
d8a28df
Compare
# Conflicts: # exposed-java-time/src/main/kotlin/org/jetbrains/exposed/sql/java-time/JavaDateColumnType.kt # gradle.properties
Contributor
|
@tnleeuw , hi, can you please check |
Author
Hi, Thanks for having a look at the PR! |
This was referenced Oct 26, 2021
Contributor
|
This current behavior is very strange! |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #221
Use a
timestamp with timezoneto storejava.time.Instantin UTC where possible; for MySQL usetimestamptype which always stores data in UTC.Works in Progress.