Escape unicode filenames to fix incorrect mappings on some platforms#789
Closed
tlundeen wants to merge 1 commit intoJesusFreke:masterfrom
Closed
Escape unicode filenames to fix incorrect mappings on some platforms#789tlundeen wants to merge 1 commit intoJesusFreke:masterfrom
tlundeen wants to merge 1 commit intoJesusFreke:masterfrom
Conversation
tlundeen
commented
Oct 14, 2020
tlundeen
commented
JesusFreke
added a commit
that referenced
this pull request
Feb 17, 2021
Some unicode characters are considered equivalent for filename purposes on mac. This adds logic to treat these collisions the same way as case sensitivy collisions are currently handled -- by adding a numeric suffix to the file/directory anytime there is a collision. See pull request #789 for more information.
Owner
|
Hi, thanks for the report and pull request. I actually solved this problem slightly differently in 1e655c2, ensuring that this type of collision is handled the same as something like a collision due to case insensitivity. |
Author
|
Thanks!
… On Feb 16, 2021, at 4:55 PM, Ben Gruver ***@***.***> wrote:
Hi, thanks for the report and pull request. I actually solved this problem slightly differently in 1e655c2 <1e655c2>, ensuring that this type of collision is handled the same as something like a collision due to case insensitivity.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#789 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AARAJL5YXOKZIQTFAYXY4MTS7MHZLANCNFSM4SQ6XIPQ>.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.