Skip to content

Add TypeScript tests using dtslint#251

Merged
dcousens merged 1 commit intoJedWatson:masterfrom
remcohaszing:test-types
May 12, 2021
Merged

Add TypeScript tests using dtslint#251
dcousens merged 1 commit intoJedWatson:masterfrom
remcohaszing:test-types

Conversation

@remcohaszing
Copy link
Copy Markdown
Contributor

This asserts the types work in TypeScript 3.0 and above. Some issues were uncovered by the tests. These have been fixed.

Closes #249

This asserts the types work in TypeScript 3.0 and above. Some issues were
uncovered by the tests. These have been fixed.
Copy link
Copy Markdown
Collaborator

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcousens
Copy link
Copy Markdown
Collaborator

dcousens commented May 9, 2021

This looks fantastic @remcohaszing, I'll merge today and test with this locally 👍

@dcousens dcousens merged commit dec702a into JedWatson:master May 12, 2021
@dcousens
Copy link
Copy Markdown
Collaborator

dcousens commented May 12, 2021

Awesome @remcohaszing! Great work.

I moved the tests to tests/types.ts and added the same test cases that are in JS files for redundancy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test the Typescript types

2 participants