TypeScript <3.7 support by self-reference type rewrite#248
Merged
dcousens merged 3 commits intoJedWatson:masterfrom May 5, 2021
coadan:236-extended-typescript-support
Merged
TypeScript <3.7 support by self-reference type rewrite#248dcousens merged 3 commits intoJedWatson:masterfrom coadan:236-extended-typescript-support
dcousens merged 3 commits intoJedWatson:masterfrom
coadan:236-extended-typescript-support
Conversation
coadan
commented
May 5, 2021
Author
coadan
left a comment
coadan
left a comment
There was a problem hiding this comment.
Just squash when merging to master, I realized that the type that I suggested in the issue was not entierly correct when reviewing the code after my morning coffee. The array type should be part of its own generic and the ArgumentArray in the Argument type should not have [] symbol after it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.