Show Goal and Statistics in the Journal#186
Merged
Jarno458 merged 3 commits intoJarno458:masterfrom Sep 25, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the "Quests" and "Feats" menus in the journal which are unused in the randomizer with "Statistics", which can show information about the seed, and "Objectives" which shows win conditions
While "Objectives" currently has a single "Goal" objective, representing the two win states, the motivator for changing this menu is to support an upcoming win state where the goal is to to complete a number of additional tasks from a provide list before performing the goal state; these tasks would include tasks that are currently feats and quests, which is why those menus are being replaced.
As this is a much more involved feature, this will be worked on later, but the UI changes could be leveraged now with our current win conditions.