Add Lab Power Safety Adjustments#185
Merged
Jarno458 merged 4 commits intoJarno458:masterfrom Sep 25, 2025
Merged
Conversation
TriumphantBass
commented
Jul 21, 2025
| Add(new ItemKey(11, 23, 280, 169), "Lab: Spider Hell Entrance Lantern 2", null, LabResearchWing & R.CardA & LanternCube); | ||
| Add(new ItemKey(11, 3, 1448, 489), "Lab: Lower Trash Lantern 1", null, MainLab & (FloodsFlags.Lab ? R.Free : (SeedOptions.LockKeyAmadeus ? DoubleJumpOfNpc : R.UpwardDash)) & LanternCube); | ||
| Add(new ItemKey(11, 3, 152, 489), "Lab: Lower Trash Lantern 2", null, MainLab & (FloodsFlags.Lab ? R.Free : (SeedOptions.LockKeyAmadeus ? DoubleJumpOfNpc : R.UpwardDash)) & LanternCube); | ||
| Add(new ItemKey(11, 3, 1448, 489), "Lab: Lower Trash Lantern 1", null, MainLab & NeedSwimming(FloodsFlags.Lab) & LanternCube); |
Collaborator
Author
There was a problem hiding this comment.
turns out both of these lanterns were on the ground and did not need any vertical
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds "safety" options for the four checks affected by the lab's power state.
Before, we had to make the logic for them restrictive to require infinite vertical, despite all four being reachable with just timestop and double jump when the lab is powered.
This PR makes it so that alternative routes that only need double jump and not infinite are available after shutting off power.
Note that none of the above changes apply when the lab is powered, which also means they will never apply in LockKeyAmadeus.
Videos are too large to attach here and are provided in the discord.