Fix moat journal logic for Gate Keep flag#176
Merged
Jarno458 merged 1 commit intoJarno458:masterfrom May 1, 2025
Merged
Conversation
Collaborator
|
Logic fix is good, but looking at this it makes me notice the display title should say Same with https://github.com/Jarno458/TsRandomizer/blob/master/TsRandomizer/Randomisation/ItemLocationMap.cs#L440 which has the correct display name but wrong area name header |
Owner
|
I specifically named it Forest and not castle, while it might be part of the castle map, for a player its outside the castle so forest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noticed on Discord, you don't need to wait for the drawbridge to be open to get this item.