Adjust logic for lore check in Maw cave#169
Merged
Jarno458 merged 1 commit intoJarno458:masterfrom Apr 8, 2025
Merged
Conversation
sgrunt
commented
Feb 10, 2025
| Add(new ItemKey(6, 25, 152, 145), "Royal Towers: Journal - Near Bottom Struggle Juggle (Mission Findings)", null, MidRoyalTower & (FloodsFlags.CastleCourtyard ? R.Free : DoubleJumpOfNpc)); | ||
| areaName = "Caves of Banishment (Maw)"; | ||
| Add(new ItemKey(8, 36, 136, 145), "Caves of Banishment (Maw): Journal - Lower Left Caves (Naivety)", null, CavesOfBanishmentFlooded); | ||
| Add(new ItemKey(8, 36, 136, 145), "Caves of Banishment (Maw): Journal - Lower Left Caves (Naivety)", null, CavesOfBanishmentFlooded | (R.GateMaw & NeedSwimming(FloodsFlags.Maw))); |
Author
There was a problem hiding this comment.
I'm somewhat sure (but not completely sure) that R.GateMaw only gets set if it's the designated warp location from Pyramid Key and/or Timeworn Warp Beacon, in which case the area's guaranteed not to be flooded, meaning this could probably be simplified to just | R.GateMaw.
Owner
There was a problem hiding this comment.
This is correct, but its also an implementation detail you likely wont think about when you review this code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion on Discord, if we get the warp to Maw cave, this location is not considered to be in logic without double jump; it's quite accessible without double jump (even if it necessitates fighting through a room with several enemies to do so).
Notably, the apworld logic for this check does not require double jump to get to the location, which I'd argue is correct.