Repository navigation
Fix flipbook selection preview offsets - #3842
Merged
JannisX11 merged 1 commit intoOct 23, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3079.
Selection previews must remove the current frame's height before converting texture coordinates to display pixels. Using the texture width instead offsets rectangle/ellipse previews and layer transform handles on non-square frames. The lasso path and its closing marker now remove the same frame offset.
Apply the offset only while the texture is animated, so changing its UV size to match the full image also keeps static previews aligned.
Validation from the repository root:
npm run build-webnpm run build-electronnpm run generate-typesBrowser automation in Chromium covered rectangle, ellipse and lasso selections on 16x16, 16x32 and 32x16 frames, at the first, second and fifth frames; final selected pixels; layer handles at two zoom levels; undo/redo of selection-to-layer; and changing an animated texture to static. Native desktop execution was not tested.
To reproduce: create a 16x32 image, use Image > Resize to keep that frame size with five animation frames, then select the second frame and drag a selection. Repeat with 32x16 frames. The live outline should follow the pointer and agree with the selection after release.