Skip to content

Comments

[Release] Version 4#589

Merged
JamesIves merged 36 commits intodevfrom
dev-v4
Feb 6, 2021
Merged

[Release] Version 4#589
JamesIves merged 36 commits intodevfrom
dev-v4

Conversation

@JamesIves
Copy link
Owner

@JamesIves JamesIves commented Feb 5, 2021

Release Checklist

I will merge this once all the pre-merge tasks are done. Should be released later today/tomorrow morning!

Pre-merge

  • - Update README, full read through.
  • - Archive v3 under the dev-v3 branch.
  • - Beef up branch protection rules.
  • - Branch cleanup
  • - Add finalized logo
  • - Write migration guide from v3 -> v4
  • - Ensure releases/v4 is up to date with dev-v4.
  • - Archive master as dev-v2.
  • - Write changelog

Post-merge

  • - Cut release on npm/github.
  • - Update releases/v4 with dev.

Post release

Pike and others added 30 commits December 7, 2020 10:11
* Stop checking out base branch before deployment, drop option.

* Don't check out default branch, as we don't check out base branch, drop option.

* Don't stash/unstash as we don't update the workdir, drop preserve option.

* Don't init the workspace

* Only fetch the remote branch if it exists, only with depth 1.

* Rely on previous checkouts to have handled lfs files correctly, drop option.

* Update README, action.yml, integration tests
* Token simplification

* Access Token / Github Token -> Token

* Oops

* Typos

* Update README.md

* Update README.md

* Update action.yml

Co-authored-by: Axel Hecht <[email protected]>

* Update README.md

Co-authored-by: Axel Hecht <[email protected]>

* Update README.md

Co-authored-by: Axel Hecht <[email protected]>
Also, add the dev and release branches, and drop master.
* Add a build step to create lib and node_modules artifact

* Run integration test with built dist and current SHA as base

For pull requests, the github.sha is the sha of the merge to the
target branch, not the head of the PR. Special case that.

* Use v2 checkout, and DRY_RUN for the integration test.

I also made the branches more generic, as there are now more of them.

* Fix #536, don't push at all on dryRun

Also add tests for dryRun and singleCommit and generateBranch
code flows.

* Try to fix dryRun on new remote branches, refactor fetch

* Try to fix dryRun, only fetch if origin branch exists

* Refactor worktree setup to include branch generation and setup for singleCommit

This is a continuation of the no-checkout work, and sadly suggested pretty
intensive changes.

* Set up git config to fix tests, also make debugging easier

* Add matrix for existing and non-existing branch

* Add matrix for singleCommit and not

* Drop GITHUB_TOKEN, add DRY_RUN to action.yml

* When deploying existing branch, add a modifcation and deploy again

* Force branch checkout to work in redeployment scenarios

* Make singleCommit easier to see in job descriptions

* Review comments

* Add a test-only property to action to test code paths with remote branch.

* Introduce TestFlag enum to signal different test scenarios to unit tests

* Fix util.test.ts
#546)

* Fix a few nits in tests and automation. Don't try to wordcount ls-remote.

Nits in tests are around undoing changes made to the environment,
and to not modify the checkout.

* Describe suite with empty SHA
* Lowercases inputs

* Adjusts workflow tests and deployment_status
As this change is subtle, I'm taking the opportunity to change
the underscore for the hyphen, which makes it less likely that
users of this action will just pass in an old json array.
* Hyphenate inputs and outputs, add step output, fix #558

I've also tried to make the clean docs a bit clearer, and consistent
about clean being on my default. Still not totally happy with the intro
of the docs there, though.

* Add testing of step outputs to build integration tests
This reverts commit 639ff53.
* SSH Key Support 🔑

* Update ssh.ts

* Update src/ssh.ts

Co-authored-by: Axel Hecht <[email protected]>

* README fixes/etc

* Unit Tests & README

* ssh key

* Update README.md

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update integration.yml

Co-authored-by: Axel Hecht <[email protected]>
* Update git.ts

* Tests

* Update git.ts

* Formatting

* Update src/git.ts

Co-authored-by: Axel Hecht <[email protected]>

* TestFlag

* Logging

* Update git.ts

Co-authored-by: Axel Hecht <[email protected]>
@JamesIves JamesIves self-assigned this Feb 5, 2021
@JamesIves JamesIves added release 🎉 The contents of this PR are related to a release. version 4 Issues related to version 4 of this action. labels Feb 5, 2021
@JamesIves JamesIves merged commit 4421827 into dev Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release 🎉 The contents of this PR are related to a release. version 4 Issues related to version 4 of this action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants