Skip to content

Comments

Deployment Issues#583

Merged
JamesIves merged 9 commits intodev-v4from
origin-fix
Feb 4, 2021
Merged

Deployment Issues#583
JamesIves merged 9 commits intodev-v4from
origin-fix

Conversation

@JamesIves
Copy link
Owner

Description

Provide a description of what your changes do.

Resolves issues #580 #579 and #582

Guessing the origin stuff got removed by mistake as it's referenced in the tests

Testing Instructions

Give us step by step instructions on how to test your changes.

  • Point workflow to releases/v4-beta, run the workflows listed in the issues!

Additional Notes

Anything else that will help us test the pull request.

N/A

@JamesIves JamesIves changed the base branch from dev to dev-v4 February 3, 2021 14:29
}
} catch {
info('Attempted to remove origin but failed, continuing…')
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually doing something? Or did you want to put the execute into the try-catch block, too?

If so, I'd hand an extra flag to isTest to fake the error here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah I just noticed that I didn't add the rm command in the try catch. I've updated the PR with an additional test flag for the test case too.

JamesIves and others added 2 commits February 3, 2021 09:51
@JamesIves
Copy link
Owner Author

JamesIves commented Feb 3, 2021

Also resolves #581 - I silenced the output from these as the logging was quite spammy. I added an info call to indicate what the action is doing in that step in place of raw log output.

Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JamesIves JamesIves merged commit a099e5d into dev-v4 Feb 4, 2021
@JamesIves JamesIves deleted the origin-fix branch February 4, 2021 02:26
@JamesIves
Copy link
Owner Author

JamesIves commented Feb 4, 2021

Woot! I'm aiming to launch v4 Saturday morning, if not sooner.

JamesIves added a commit that referenced this pull request Feb 6, 2021
* Stop checking out workspace (#515)

* Stop checking out base branch before deployment, drop option.

* Don't check out default branch, as we don't check out base branch, drop option.

* Don't stash/unstash as we don't update the workdir, drop preserve option.

* Don't init the workspace

* Only fetch the remote branch if it exists, only with depth 1.

* Rely on previous checkouts to have handled lfs files correctly, drop option.

* Update README, action.yml, integration tests

* Set up eslint for test files. (#517)

* Add DRY_RUN option, passing --dry-run to git push. (#526)

See #499 for the proposal.

* Simplifies Token Setup (#530)

* Token simplification

* Access Token / Github Token -> Token

* Oops

* Typos

* Update README.md

* Update README.md

* Update action.yml

Co-authored-by: Axel Hecht <[email protected]>

* Update README.md

Co-authored-by: Axel Hecht <[email protected]>

* Update README.md

Co-authored-by: Axel Hecht <[email protected]>

* Adjust codeql action to latest recommendations (#540)

Also, add the dev and release branches, and drop master.

* Add workflow to update build and node_modules on release branches (#541)

* Stores username/email in secrets

* Removing stale bot integration

* Test current code base as an integration test for PRs and pushes (#505)

* Add a build step to create lib and node_modules artifact

* Run integration test with built dist and current SHA as base

For pull requests, the github.sha is the sha of the merge to the
target branch, not the head of the PR. Special case that.

* Use v2 checkout, and DRY_RUN for the integration test.

I also made the branches more generic, as there are now more of them.

* Fix #536, don't push at all on dryRun

Also add tests for dryRun and singleCommit and generateBranch
code flows.

* Try to fix dryRun on new remote branches, refactor fetch

* Try to fix dryRun, only fetch if origin branch exists

* Refactor worktree setup to include branch generation and setup for singleCommit

This is a continuation of the no-checkout work, and sadly suggested pretty
intensive changes.

* Set up git config to fix tests, also make debugging easier

* Add matrix for existing and non-existing branch

* Add matrix for singleCommit and not

* Drop GITHUB_TOKEN, add DRY_RUN to action.yml

* When deploying existing branch, add a modifcation and deploy again

* Force branch checkout to work in redeployment scenarios

* Make singleCommit easier to see in job descriptions

* Review comments

* Add a test-only property to action to test code paths with remote branch.

* Introduce TestFlag enum to signal different test scenarios to unit tests

* Fix util.test.ts

* Update worktree.ts

* Fix a few nits in tests and automation. Don't try to wordcount ls-rem… (#546)

* Fix a few nits in tests and automation. Don't try to wordcount ls-remote.

Nits in tests are around undoing changes made to the environment,
and to not modify the checkout.

* Describe suite with empty SHA

* Lowercase Inputs (#547)

* Lowercases inputs

* Adjusts workflow tests and deployment_status

* Use multi-line string for clean-exclude patterns. (#553)

As this change is subtle, I'm taking the opportunity to change
the underscore for the hyphen, which makes it less likely that
users of this action will just pass in an old json array.

* Hyphenate inputs and outputs, add step output, fix #558 (#559)

* Hyphenate inputs and outputs, add step output, fix #558

I've also tried to make the clean docs a bit clearer, and consistent
about clean being on my default. Still not totally happy with the intro
of the docs there, though.

* Add testing of step outputs to build integration tests

* Security Docs

* Integration tests

* Revert "Integration tests"

This reverts commit 639ff53.

* Native SSH Key Support (#569)

* SSH Key Support 🔑

* Update ssh.ts

* Update src/ssh.ts

Co-authored-by: Axel Hecht <[email protected]>

* README fixes/etc

* Unit Tests & README

* ssh key

* Update README.md

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update integration.yml

Co-authored-by: Axel Hecht <[email protected]>

* Deployment Issues (#583)

* Update git.ts

* Tests

* Update git.ts

* Formatting

* Update src/git.ts

Co-authored-by: Axel Hecht <[email protected]>

* TestFlag

* Logging

* Update git.ts

Co-authored-by: Axel Hecht <[email protected]>

* Codespace Support (#584)

* Add files via upload

* Update README.md

* Add files via upload

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* SSH Issues (#588)

* Unsets Persisted Credentials (#587)

* Persist

* Config Setup/Tests

* Assets

* Update git.ts

* Spacing

* Update integration.yml

* Update README.md

Co-authored-by: Axel Hecht <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version 4 Issues related to version 4 of this action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants