Skip to content

Comments

Lowercase Inputs#547

Merged
JamesIves merged 2 commits intodev-v4from
lowercase-envs
Dec 15, 2020
Merged

Lowercase Inputs#547
JamesIves merged 2 commits intodev-v4from
lowercase-envs

Conversation

@JamesIves
Copy link
Owner

Description

Provide a description of what your changes do.

Lowercases inputs in the README and constants.ts file.

Testing Instructions

Give us step by step instructions on how to test your changes.

  • Ensure that the variables still work.

Additional Notes

Anything else that will help us test the pull request.

I did not lower case the environment variable export DEPLOYMENT_STATUS as it's common for environment variables to be uppercase. But I can probably be convinced to lowercase this too if anyone has a strong opinion.

@JamesIves JamesIves added the version 4 Issues related to version 4 of this action. label Dec 15, 2020
@JamesIves
Copy link
Owner Author

JamesIves commented Dec 15, 2020

Looks like some branch teardown is needed in the new integration tests, but they are working well which is super awesome 😄

@Pike
Copy link
Contributor

Pike commented Dec 15, 2020

Can you rerun the test? Looking at the log, it seems to think that the remote branch doesn't exist, and I wonder if that's a mid-air with an integration test elsewhere or something.

@JamesIves JamesIves linked an issue Dec 15, 2020 that may be closed by this pull request
Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to change action.yml as well as the workflows, too?

Re DEPLOYMENT_STATUS, is the environment variable offering something that setOutput wouldn't? The latter would be lower-case, but I was wondering in general 😉

@JamesIves
Copy link
Owner Author

Ah yes good point, forgot about those:

  • Lowercased all inputs in workflows including deployment_status.
  • Made the adjustments for the token variable.
  • Removed token: when github_token is used so those are properly tested.
  • Switched scheduled integration tests to releases/v4
  • Removed integration-beta tests in favour of the new PR based integration tests.

Copy link
Contributor

@Pike Pike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, happy to see the beta test go.

@JamesIves JamesIves merged commit d8c7953 into dev-v4 Dec 15, 2020
@JamesIves JamesIves deleted the lowercase-envs branch December 15, 2020 23:32
JamesIves added a commit that referenced this pull request Feb 6, 2021
* Stop checking out workspace (#515)

* Stop checking out base branch before deployment, drop option.

* Don't check out default branch, as we don't check out base branch, drop option.

* Don't stash/unstash as we don't update the workdir, drop preserve option.

* Don't init the workspace

* Only fetch the remote branch if it exists, only with depth 1.

* Rely on previous checkouts to have handled lfs files correctly, drop option.

* Update README, action.yml, integration tests

* Set up eslint for test files. (#517)

* Add DRY_RUN option, passing --dry-run to git push. (#526)

See #499 for the proposal.

* Simplifies Token Setup (#530)

* Token simplification

* Access Token / Github Token -> Token

* Oops

* Typos

* Update README.md

* Update README.md

* Update action.yml

Co-authored-by: Axel Hecht <[email protected]>

* Update README.md

Co-authored-by: Axel Hecht <[email protected]>

* Update README.md

Co-authored-by: Axel Hecht <[email protected]>

* Adjust codeql action to latest recommendations (#540)

Also, add the dev and release branches, and drop master.

* Add workflow to update build and node_modules on release branches (#541)

* Stores username/email in secrets

* Removing stale bot integration

* Test current code base as an integration test for PRs and pushes (#505)

* Add a build step to create lib and node_modules artifact

* Run integration test with built dist and current SHA as base

For pull requests, the github.sha is the sha of the merge to the
target branch, not the head of the PR. Special case that.

* Use v2 checkout, and DRY_RUN for the integration test.

I also made the branches more generic, as there are now more of them.

* Fix #536, don't push at all on dryRun

Also add tests for dryRun and singleCommit and generateBranch
code flows.

* Try to fix dryRun on new remote branches, refactor fetch

* Try to fix dryRun, only fetch if origin branch exists

* Refactor worktree setup to include branch generation and setup for singleCommit

This is a continuation of the no-checkout work, and sadly suggested pretty
intensive changes.

* Set up git config to fix tests, also make debugging easier

* Add matrix for existing and non-existing branch

* Add matrix for singleCommit and not

* Drop GITHUB_TOKEN, add DRY_RUN to action.yml

* When deploying existing branch, add a modifcation and deploy again

* Force branch checkout to work in redeployment scenarios

* Make singleCommit easier to see in job descriptions

* Review comments

* Add a test-only property to action to test code paths with remote branch.

* Introduce TestFlag enum to signal different test scenarios to unit tests

* Fix util.test.ts

* Update worktree.ts

* Fix a few nits in tests and automation. Don't try to wordcount ls-rem… (#546)

* Fix a few nits in tests and automation. Don't try to wordcount ls-remote.

Nits in tests are around undoing changes made to the environment,
and to not modify the checkout.

* Describe suite with empty SHA

* Lowercase Inputs (#547)

* Lowercases inputs

* Adjusts workflow tests and deployment_status

* Use multi-line string for clean-exclude patterns. (#553)

As this change is subtle, I'm taking the opportunity to change
the underscore for the hyphen, which makes it less likely that
users of this action will just pass in an old json array.

* Hyphenate inputs and outputs, add step output, fix #558 (#559)

* Hyphenate inputs and outputs, add step output, fix #558

I've also tried to make the clean docs a bit clearer, and consistent
about clean being on my default. Still not totally happy with the intro
of the docs there, though.

* Add testing of step outputs to build integration tests

* Security Docs

* Integration tests

* Revert "Integration tests"

This reverts commit 639ff53.

* Native SSH Key Support (#569)

* SSH Key Support 🔑

* Update ssh.ts

* Update src/ssh.ts

Co-authored-by: Axel Hecht <[email protected]>

* README fixes/etc

* Unit Tests & README

* ssh key

* Update README.md

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update ssh.test.ts

* Update integration.yml

Co-authored-by: Axel Hecht <[email protected]>

* Deployment Issues (#583)

* Update git.ts

* Tests

* Update git.ts

* Formatting

* Update src/git.ts

Co-authored-by: Axel Hecht <[email protected]>

* TestFlag

* Logging

* Update git.ts

Co-authored-by: Axel Hecht <[email protected]>

* Codespace Support (#584)

* Add files via upload

* Update README.md

* Add files via upload

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* SSH Issues (#588)

* Unsets Persisted Credentials (#587)

* Persist

* Config Setup/Tests

* Assets

* Update git.ts

* Spacing

* Update integration.yml

* Update README.md

Co-authored-by: Axel Hecht <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

version 4 Issues related to version 4 of this action.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make inputs in README lowercase

2 participants