Skip to content

A few nits #545

@Pike

Description

@Pike

Describe the bug

While looking through the code, I came across a few details that would be good to fix up.

fs.createWriteStream('assets/.nojekyll')
fs.createWriteStream('assets/CNAME')
modifies the local check-out, w/out undoing the changes.

process.env.GITHUB_SHA = ''
modifies the environment of the tests w/out undoing the changes. Also seems to test a branch in the commit message generation that's not covered elsewhere, but also isn't part of the test description?

https://github.com/JamesIves/github-pages-deploy-action/blob/dev-v4/src/git.ts#L58 doesn't actually run the | wc -l part, as it's not a shell. Well, it runs it, in the sense that it just passes them as options to the git command.

Metadata

Metadata

Assignees

No one assigned

    Labels

    improvement ✨Improvement suggestion.version 4Issues related to version 4 of this action.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions