Skip to content
This repository was archived by the owner on Jan 14, 2019. It is now read-only.

fix: Fix issues with parsing types and directives #65

Merged
JamesHenry merged 25 commits into from
Dec 28, 2018
Merged

fix: Fix issues with parsing types and directives #65

JamesHenry merged 25 commits into from
Dec 28, 2018

Conversation

@armano2
Copy link
Contributor

@armano2 armano2 commented Dec 26, 2018 •
edited
Loading

This PR contains fixes related to parsing types and fix for parsing directives.

Changelog:

This PR contains changes from: #63, #56, #62, #61, #55

i made one PR out of all of those changes, to test if everything is going to work correctly when all of them are applied at same time

@j-f1 @uniqueiniquity @JamesHenry

fixes: #16 #2 #64

armano2 added 18 commits December 25, 2018 23:23
@armano2
fix: add proper support for unsupported types
0a800e3
@armano2
fix: add missing TSAbstractClassDeclaration in ast-node-types
5e3498b
@armano2
test: correct test for TSParenthesizedType
052c073
@armano2
fix: add missing TSBigIntKeyword to ast-node-types
51e15b5
@armano2
test: add test cases for true/false typed keywords
d3704b1
@armano2
test: add keyword: never, null, object, symbol, undefined, unknown, void
410386d
@armano2
chore: add links to issues
672f0f8
@armano2
fix: add missing BigIntKeyword to isTypeKeyword
010f0cb
@armano2
fix: correct detection of destructing assigment
aa048d8
@armano2
test: enable tests
4061041
@armano2
test: change babel sourceType to unambiguous
9e3a7b4
@armano2
chore: update message
1624c13
@armano2
chore: update comments
2859fa2
@armano2
fix: add directive field to ExpressionStatement
64465e3
@armano2
fix: add TSTypeQuery and TSIndexedAccessType to supported types
d2aada2 
add additional tests for types
@armano2
fix: add TSConditionalType to known types
35e483c
@armano2
fix: add TSRestType to known types
aa59b4f
@armano2
test: fix rebase conflict
90319aa
@armano2 armano2 changed the title Alignment: fix issues in parser Alignment: fix issues in converter Dec 26, 2018
@armano2
fix: treeNodeMaps for types and add typeMode
5a568c5 
Additionally fix issue that Object literal is not TypeReference
@armano2 armano2 changed the title Alignment: fix issues in converter fix: Fix issues with parsing types and directives Dec 26, 2018
uniqueiniquity
uniqueiniquity reviewed Dec 26, 2018
View reviewed changes
uniqueiniquity
uniqueiniquity previously approved these changes Dec 26, 2018
View reviewed changes
@armano2
Copy link
Contributor Author

armano2 commented Dec 27, 2018 •
edited
Loading

@uniqueiniquity i found bug that directives inside modules and namespaces was not marked as such
(i had to to fix for that).

see: https://github.com/Microsoft/TypeScript/wiki/What%27s-new-in-TypeScript#modules-are-now-emitted-with-a-use-strict-prologue

and for now i'm not fixing other issues, this commit is to big anyway...

@JamesHenry
Copy link
Owner

JamesHenry commented Dec 27, 2018

@armano2 Should I wait until you let me know you are ready? Thanks again for all the hard work

@armano2
Copy link
Contributor Author

armano2 commented Dec 27, 2018 •
edited
Loading

@JamesHenry this pr is completed, and issue with modules/namespaces got solved in 5b6632d

JamesHenry
JamesHenry approved these changes Dec 28, 2018
View reviewed changes
Copy link
Owner

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @armano2! This is some huge progress.

Hopefully in future we can avoid such large PRs as it doesn't work so well with the semantic-release concept, but I appreciate you have folded together multiple streams of work that I hadn't had chance to take a look at separately (due to being on Christmas vacation).

There are also breaking changes within this which are not actually called out I don't think, so I am going to mark the whole thing are "breaking" and refer people back to this PR to get full details.

I'm sure typescript-eslint-parser and prettier will need some updates after this!

@JamesHenry JamesHenry merged commit 969c0d3 into JamesHenry:master Dec 28, 2018
@JamesHenry
Copy link
Owner

JamesHenry commented Dec 28, 2018

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@armano2 armano2 deleted the aligment branch December 28, 2018 18:30
@armano2
Copy link
Contributor Author

armano2 commented Dec 28, 2018

@JamesHenry had no support for those nodes, and i just pushed PR witch add them to visitor keys in
eslint/typescript-eslint-parser@34adb5d

@armano2 armano2 mentioned this pull request Dec 28, 2018
Closed
@armano2
Copy link
Contributor Author

armano2 commented Dec 28, 2018

i will try doing smaller patches now :)

@JamesHenry JamesHenry mentioned this pull request Jan 6, 2019
Closed
This was referenced Jan 8, 2019
Merged
Merged
JamesHenry pushed a commit to typescript-eslint/typescript-eslint that referenced this pull request Jan 13, 2019
@armano2 @JamesHenry
fix: many missing nodes and better babel alignment (#65)
60f4f25 
BREAKING CHANGE: We apologise for the lack of a granular changelog here. There are multiple changes to the AST in this large commit, please see the PR JamesHenry/typescript-estree#65 for full details
JamesHenry pushed a commit to typescript-eslint/typescript-eslint that referenced this pull request Jan 13, 2019
@armano2 @JamesHenry
fix: many missing nodes and better babel alignment (#65)
e2ef714 
BREAKING CHANGE: We apologise for the lack of a granular changelog here. There are multiple changes to the AST in this large commit, please see the PR JamesHenry/typescript-estree#65 for full details
JamesHenry pushed a commit to typescript-eslint/typescript-eslint that referenced this pull request Jan 13, 2019
@armano2 @JamesHenry
fix: many missing nodes and better babel alignment (#65)
c1ec4aa 
BREAKING CHANGE: We apologise for the lack of a granular changelog here. There are multiple changes to the AST in this large commit, please see the PR JamesHenry/typescript-estree#65 for full details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

@uniqueiniquity uniqueiniquity uniqueiniquity left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for TSTupleType and TSAbstractClassDeclaration in ast-node-types.js

3 participants

@armano2 @JamesHenry @uniqueiniquity