Skip to content

Add support for incremental annotation processing#1546

Merged
JakeWharton merged 1 commit intoJakeWharton:masterfrom
gavra0:isolating-ap
Sep 5, 2019
Merged

Add support for incremental annotation processing#1546
JakeWharton merged 1 commit intoJakeWharton:masterfrom
gavra0:isolating-ap

Conversation

@gavra0
Copy link
Copy Markdown
Contributor

@gavra0 gavra0 commented Aug 28, 2019

This commit adds incremental annotation processing support
to Butterknife. More specifically, it makes Butterknife an
isolating annotation processor. More information about what
this means can be found at
https://docs.gradle.org/current/userguide/java_plugin.html#isolating_annotation_processors.

Closes #1230

@JakeWharton JakeWharton force-pushed the isolating-ap branch 2 times, most recently from 0970fb3 to 7e1310f Compare September 5, 2019 02:48
This commit adds incremental annotation processing support
to Butterknife. More specifically, it makes Butterknife an
isolating annotation processor. More information about what
this means can be found at
https://docs.gradle.org/current/userguide/java_plugin.html#isolating_annotation_processors.
@JakeWharton JakeWharton merged commit 163c9ab into JakeWharton:master Sep 5, 2019
@stephanenicolas
Copy link
Copy Markdown
Contributor

Does it work incrementally when a subclass is modified but its superclass is unchanged ?
This was the reason why I had also addressed inerhitance across modules along with incrementality. I might be wrong though..

@gavra0
Copy link
Copy Markdown
Contributor Author

gavra0 commented Sep 5, 2019

Support for finding parent bindings in .class files (and classpath) has been added in #1545, so that use-case should work.

@stephanenicolas
Copy link
Copy Markdown
Contributor

stephanenicolas commented Sep 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants