Bring up to date#1
Merged
Merged
Conversation
…DULE_DB environment variable. (#3056) By default Celery will use a file celerybeat-schedule in the current directory. This is an issue in a Kubernetes/Openshift environment as the file may be lost or even impossible to write.
* add last_active_at to users page * Use our JSON encoder as the SQLAlchemy JSON serializer. * Fixed some inconsistencies in the user query class methods. * Minor cosmetic fixes. * Add some make tasks for easier development. * Add user detail sync system based on Redis backend. There is a periodic Celery task that updates a new “details” JSONB column in the “user” table with the data from Redis. Currently this is only used for tracking the date of last activity of a user but can be extended with other user information later. Updates a few dependencies. * Normalize a few Flask extension API names. * Reduce implementation complexity of JSONEncoder. * Use request_started signal to make sure we have a request context. Otherwise loading the user based on the request won’t work. * Fix test that checks if disabled users can login. This correctly uses a URL path that includes the current organization and checks for the error message. The previous test seems to have been a red herring. * Minor cosmetic fixes. * Remove needs_sync in favor of just deleting things. * Misc review fixes. * Ignore line length. * Split redash.models import several modules. * Move walrus UTC DateTimeField into redash.models.types. * Restore distinctly loading dashboards. * Simplify default values for user details. * Define __repr__ methods generically. * Consistently have underscore methods at the top of model methods. * Fix tests. * Split redash.models import several modules. * Update to latest walrus and redis-py. * Update kombu to 4.2.2 for redis-py 3.x compatibility. * Remove redis-cli container after running Make task. * Move buffer condition after datetime/time conditions. * Update walrus to 0.7.1. * Refactor some query APIs. This uses the flask-sqlalchemy helpers consistently and makes more use of mixins. * Post rebase fixes. * Use correct kombu version * Fix migration down revision
* determine invitation_pending according to empty password. This commit will be reverted, I'm just deferring the implementation * show '(Invitation Pending)' to users who haven't accepted their invitation yet * allow resending invitations * allow deletion of pending users from user list * set invitation as not pending when following invite link * prevent deleting activated users * test that users who follow invitation links are set as non-pending invitations * prevent re-using invitations * invitees who use SSO will now also be marked as "non-pending" * lint
Signed-off-by: koooge <[email protected]>
* Switch to simpler implementation * Fix active_at update code * Fix sync test
* default `is_invitation_pending` to false and actively set it to true when inviting users, so that existing users won't show "Invitation Pending" * fix tests that broke due to default is_invitation_pending value * update Flask-OAuthLib
* Added support for Apache Drill datasource * Improvements in `Drill` query runner and minor refactoring 1. Drill query runner now inherits from `BaseHTTPQueryRunner`, because they both have a lot of common code. 2. `BaseHTTPQueryRunner.get_response` method now accepts `http_method` argument (original implementation was only capable of sending `GET` HTTP requests). 3. Added `order` to `BaseHTTPRequestRunner` configuration schema to fix order of UI elements based on the schema. 4. Eliminated duplicate method `_guess_type` in `GoogleSpreadsheet`, `Results` and `Drill` query runners, moved `guess_type` to `redash.query_runner`. 5. Removed tests for `_guess_type` in `GoogleSpreadsheet`, `Results` and `Drill` query runners, merged them into single test case and moved to `tests.query_runner.test_utils`. 6. Various minor changes (code style, imports, etc).
…es (#3265) * Fix: Refresh schedule interval count doesn't adhere to permission rules * Fix “4.28 weeks” to “30 days” * Merge interval type and count into one <Select>
* Fix: Refresh schedule durations not pluralized sufficiently * Allows omitting single value number in durationHumanize (#3274)
* add an bit * prompt on homepage when user's email hasn't been verified * set e-mail as verified for new setups and invited users * 👋 copy & paste invite links, it's time for verified e-mails! * default `is_invitation_pending` to false and actively set it to true when inviting users, so that existing users won't show "Invitation Pending" * fix tests that broke due to default is_invitation_pending value * treat admin's e-mail address as verified * add verification endpoint * send verification e-mail * Update client/app/components/empty-state/empty-state.html Co-Authored-By: rauchy <[email protected]> * Update redash/authentication/account.py Co-Authored-By: rauchy <[email protected]> * Update redash/handlers/authentication.py Co-Authored-By: rauchy <[email protected]> * Update redash/templates/emails/verify.html Co-Authored-By: rauchy <[email protected]> * Update redash/authentication/account.py Co-Authored-By: rauchy <[email protected]> * Update redash/templates/verify.html Co-Authored-By: rauchy <[email protected]> * Update redash/templates/emails/verify.txt Co-Authored-By: rauchy <[email protected]> * add link in case redirects are disabled * POSTing to /email_verification makes more sense than GETting /send_verification * avoid sending invitations when no_invite is passed along * Update client/app/pages/users/new.html Co-Authored-By: rauchy <[email protected]> * move e-mail verification prompt to home-page * get rid of redundant $scope * return JSON * flip is_email_verified's default value so that existing users do not show as not-verified * e-mail verification propmt isn't dangerous, it just wants to warn you
* Setup enzyme and initial ScheduleDialog test * Added tests for each schedule setting * Added refreshOptions tests * Added count out-of-range tests * Added modal confirm/cancel tests * Fixed tests failing due to server timezone difference * Rebased to master
* Pleasant alert-warning colors * Fix for json viewer primitive color
* Separate Ant less dependency tree * Change order between variables and ant imports * Remove inc/variables from ant.less * Update input-height-base for antd * Set same input-color for Ant and Bootstrap
* #2641 Step 1: split Add Widget/Add Textbox buttons * Convert Add widget/textbox dialogs to React components * #2641 Step 2: Implement new dashboard parameters logic * Resolve conflicts and fix build errors * #2641 Refactoring and improve code quality * Add Edit parameter mappings dialog to the widget * #2641 Changes after code review * Use Ant's Select component instead on <select> tags * Fix Antd imports * Fix Antd imports * Fix Cannot read property 'getParametersDefs' of undefined * Fix widgets static params bugs (don't show input, don't init from URL) * Minor UI/UX fixes
* create DynamicForm React component * Render fields based on target in DynamicForm * Add missing title property to fields * Fix style properties in DynamicForm * Render File fields in DynamicForm * Use React for middle component instead of Angular * Functional save button * Update label style * Render functional actions * Handle file inputs * Update render methods to fix code climate issues * Fix ant input number showing duplicate arrows * Update DynamicForm style to be vertical * Separate imports from antd in DynamicForm * Add Feedback Icons to DynamicForm * Change Action props on DynamicForm - use type and pullRight instead of class prop - update data sources and destinations pages accordingly * Remove setDefaults method from DynamicForm fields * Update antd version * Remove unnecessary class selectors * Remove another unnecessary class selector
* explicitly look for a False under details['is_invitation_pending'] and not any falsey result, to avoid locking out invitations which were created before the Pending Invitation feature was introduced. Solves #3297 * test that old invites (that do not have any is_invitation_pending flag set in their details object) are still acceptable
Multifilter's dropdown cropped when visualization container is too small
…uded (#3600) * Fix: make sure that only the top level node_modules directory is excluded * Remove old unused packing script
* Update pack * Remove node_modules before packing
* change API to /api/queries/:id/dropdowns/:dropdown_id * extract property * split to 2 different dropdown endpoints and implement the second * make access control optional for dropdowns (assuming it is verified at a different level) * add test cases for /api/queries/:id/dropdowns/:id * use new /dropdowns endpoint in frontend * require access to dropdown queries when creating or updating parent queries * rename Query resource dropdown endpoints * check access to dropdown query associations in one fugly query * move ParameterizedQuery to models folder * add dropdown association tests to query creation * move group by query ids query into models.Query * use bound parameters for groups query * format groups query * use new associatedDropdowns endpoint in dashboards * pass down parameter and let it return dropdown options. Go Levko! * change API to /api/queries/:id/dropdowns/:dropdown_id * split to 2 different dropdown endpoints and implement the second * use new /dropdowns endpoint in frontend * pass down parameter and let it return dropdown options. Go Levko! * fix bad rebase * add comment to clarify the purpose of checking the queryId
* Apply prettier to app-header.html. * Add: E2E test for query search
Jakdaw
pushed a commit
that referenced
this pull request
Aug 13, 2019
* Dashboard grid React migration * Updated tests * Fixes comments * One col layout * Tests unskipped * Test fixes * Test fix * AutoHeight feature * Kebab-cased * Get rid of lazyInjector * Replace react-grid-layout with patched fork to fix performance issues * Fix issue with initial layout when page has a scrollbar * Decrease polling interval (500ms is too slow) * Rename file to match it's contents * Added some notes and very minor fixes * Fix Remove widget button (should be visible only in editing mode); fix widget actions menu * Fixed missing grid markings * Enhanced resize handle * Updated placeholder color * Render DashboardGrid only when dashboard is loaded
Jakdaw
pushed a commit
that referenced
this pull request
Oct 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.