Repository navigation
fix(deps): pin every patched package so the nightly desktop build installs again - #726
Conversation
…talls again The desktop build installs its staged app without a lockfile, so the server's `node-pty: ^1.2.0-beta.15` range resolved to node-pty 1.2.0-beta.18 (published 2026-10-23) and pnpm failed with ERR_PNPM_UNUSED_PATCH for the beta.15 patch. Pin each patched package with an exact override, an early port of pingdotgg#23798 at our current versions. Resolved versions in the lockfile are unchanged. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
vouch:trusted
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Pin packages and document the patch contract pnpm-workspace.yaml, FORK.md |
The workspace adds exact version pins for 18 packages and notes that they should be updated alongside patchedDependencies. FORK.md documents the ERR_PNPM_UNUSED_PATCH desktop build failure and updates the ledger for pnpm-lock.yaml and pnpm-workspace.yaml. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix · Severity of issue fixed: Medium
Suggested reviewers: juliusmarminge, bryantderosier
Merge Risk: 
9cf71
-
The exact package pins address the reported patched-install mismatch, with no remaining evidence of a merge-blocking issue.
Pre-merge checks: 
-
Check name Status Explanation Title check The title names the main change: pinning every patched package with exact overrides so the nightly desktop build installs again. It is specific, uses the conventional commit form, and matches the raw … Description check The description follows the template sections: Problem, What changed, Upstream impact, and Checklist. The Problem section names the failing nightly job, the error, and the cause. It links the job URL.… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title names the main change: pinning every patched package with exact overrides so the nightly desktop build installs again. It is specific, uses the conventional commit form, and matches the raw summary and PR objectives. The title is clear and concise, and it does not use vague terms.
Full details: Description check
-
Explanation
The description follows the template sections: Problem, What changed, Upstream impact, and Checklist. The Problem section names the failing nightly job, the error, and the cause. It links the job URL. What changed explains the pins, the FORK.md temporary patch, and the lockfile impact. Verification steps are listed. The UI changes section is omitted, which is allowed when there is no UI change. The Live testing section is also omitted. The template says to delete that section when nothing can be live-tested, and the author states there is nothing to live-test. The Problem section does not include a 'Closes #' issue link. The description says the tracking issue is not linked. The template asks for the link, so this is a minor gap. Most checklist items are checked or explained. The unchecked items have reasons stated. The description also omits the model and harness line at the end. The author did include a harness line ('Claude Opus 5.5 in J5 Code (Claude Code harness)'), so that requirement is met. Overall the description is mostly complete.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
Problem
The 2026-10-26 J5 Nightly failed in the Apple Silicon desktop build (job) with
ERR_PNPM_UNUSED_PATCH ... [email protected]. The desktop build installs its staged app without a lockfile, so the server'snode-pty: ^1.2.0-beta.15range resolved to node-pty 1.2.0-beta.18, published 2026-10-23. The beta.15 patch then matched nothing. Every desktop build since node-pty's new betas has this failure, not only tonight's.What changed
pnpm-workspace.yamlnow pins each patched package that lacked one with an exact override. This is an early port of upstream's own fix, pingdotgg#23798, at our current versions (upstream's are newer in places). The staged install already copies the workspace overrides, so it now resolves the patched versions. Upstream's fix arrives with the v0.1.3 advance (#705), which is not landing soon. FORK.md records this as a temporary patch that exits at that advance.The lockfile changes only in its
overridesand specifier lines. Every resolved version is unchanged.Verified:
node-pty: ^1.2.0-beta.15plus the patch): it fails with the sameERR_PNPM_UNUSED_PATCHwithout the pin, and installs the patched beta.15 with it.node scripts/release-smoke.tspasses.Upstream impact
pnpm-workspace.yaml,pnpm-lock.yaml: the temporary patch "Every patched package has an exact override" in FORK.md, plus ledger rows. It is upstream's fix landed early, not a divergence.Checklist
FORK.md(case text and file-table row) in this PRClaude Opus 5.5 in J5 Code (Claude Code harness).
🤖 Generated with Claude Code