Skip to content

Update download comment at PR if PR closed#10057

Merged
calixtus merged 6 commits intomainfrom
remove-comment
Jul 3, 2023
Merged

Update download comment at PR if PR closed#10057
calixtus merged 6 commits intomainfrom
remove-comment

Conversation

@koppor
Copy link
Copy Markdown
Member

@koppor koppor commented Jul 3, 2023

We also have an action adding a link to the build at the PR (

- name: Comment PR
). We have an action removing the branch on builds.jabref.org (https://github.com/JabRef/jabref/blob/main/.github/workflows/cleanup_pr.yml). Then, the link is 404. Thus, the comment should be deleted. This PR tries that.

Mandatory checks

@koppor koppor closed this Jul 3, 2023
@koppor
Copy link
Copy Markdown
Member Author

koppor commented Jul 3, 2023

Switched to message replacing. Reasons:

  1. Deletion should delete new comment, not the "updated" one thollander/actions-comment-pull-request#247
  2. A user might be confused: "I swear, I saw a comment of the GitHub bot. Where is it now?"

@koppor koppor closed this Jul 3, 2023
@koppor koppor reopened this Jul 3, 2023
@koppor koppor closed this Jul 3, 2023
@koppor koppor reopened this Jul 3, 2023
@koppor koppor closed this Jul 3, 2023
@koppor koppor reopened this Jul 3, 2023
@koppor koppor changed the title Try to remove comment at PR Update download comment at PR if PR closed Jul 3, 2023
@koppor koppor marked this pull request as ready for review July 3, 2023 19:30
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 3, 2023

A build of this PR is not available. Head to https://builds.jabref.org/main/ for the latest build.

@calixtus calixtus merged commit 357f486 into main Jul 3, 2023
@calixtus calixtus deleted the remove-comment branch July 3, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants