Fix TypeScript subpath exports resolution under node moduleResolution#116
Merged
Fix TypeScript subpath exports resolution under node moduleResolution#116
Conversation
Add typesVersions fallback to package.json so docxodus/react and docxodus/worker resolve types under all TS module resolution modes. Reorder export conditions to put types before import per TS requirements. https://claude.ai/code/session_01DFuL5c7KNRiu4QgifBBGWV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed TypeScript subpath exports (
docxodus/reactanddocxodus/worker) not resolving correctly undermoduleResolution: "node"by adding atypesVersionsfallback configuration to package.json.Changes
typesfield beforeimportin all export entries (.,./react,./worker) to comply with TypeScript's requirement that type conditions appear firsttypesVersionsconfiguration mapping subpath exports to their corresponding.d.tsfiles, ensuring type resolution works under all TypeScript module resolution modes (node, bundler, etc.)Details
The
typesVersionsfield acts as a fallback for TypeScript versions that don't fully support the conditional exports syntax, allowing subpath imports likeimport type { ... } from 'docxodus/react'to correctly resolve their type definitions regardless of the consumer'smoduleResolutionsetting.https://claude.ai/code/session_01DFuL5c7KNRiu4QgifBBGWV