-
-
Notifications
You must be signed in to change notification settings - Fork 321
Replace svgSalamander with jsvg #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@weisJ Great work! Just tried the FlatLafDemo and if any |
|
@weisJ I also ran into a problem in
It produces an "Invalid protocol: inputStreamSVG" error. Except for this and my other report it works a lot better with randomly tested SVGs as opposed with SvgSalmander that fail with those. |
|
@weisJ many thanks for the PR and for JSVG 👍 I've reviewed it and fixed in color filter and loading from input stream issues. Will test this PR and JSVG in some other projects in the next weeks... |
|
Note that I had originally not changed the cache to take URLs as keys due to this problem: https://errorprone.info/bugpattern/URLEqualsHashCode |
|
Many thanks for this hint. Didn't know that. Changed the cache key from URL to String to avoid that. |
See #664