release/1.5.1: cherry-pick hera bug fix, macOS CI aarch64 updates, and [email protected] changes from develop#817
Merged
climbfuji merged 8 commits intoJCSDA:release/1.5.1from Oct 11, 2023
Conversation
…dd target 'haswell'
…ith the replacement qhull for tesselation and since it leads to compilation errors in ecmwf-atlas with Intel
climbfuji
changed the title
climbfuji
requested review from
AlexanderRichert-NOAA,
srherbener and
ulmononian
ulmononian
reviewed
Oct 11, 2023
ulmononian
reviewed
Oct 11, 2023
ulmononian
approved these changes
Oct 11, 2023
srherbener
reviewed
Oct 11, 2023
srherbener
approved these changes
Oct 11, 2023
Collaborator
srherbener
left a comment
srherbener
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cherry-picks the necessary commits from the develop branch to add
[email protected]and the new varianttesselationrequired for the 1.5.1 release. It further contains a bug fix for Hera (also cherry-picked from develop) and an update of the macOS aarch64 CI workflow (ditto; without this the CI tests wouldn't succeed any longer).Testing
Applications affected
Applications using
ecmwf-atlasnow have access to thetesselationfunctionality (usingqhullas an additional dependency).Systems affected
Hera
Dependencies
Issue(s) addressed
n/a
Checklist