Skip to content

Feature/updates for rc2#214

Merged
climbfuji merged 37 commits intoJCSDA:release/v1from
climbfuji:feature/updates_for_rc2
Jun 23, 2022
Merged

Feature/updates for rc2#214
climbfuji merged 37 commits intoJCSDA:release/v1from
climbfuji:feature/updates_for_rc2

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Jun 17, 2022

A number of updates for spack-stack-1.0.0 release candidate 2:

  • Update CI tests to use jedi-ufs-all template
  • Fix create-spack-mirror CI test
  • Add yaksa modulefile to blacklist
  • Do not pin version for py-setuptools
  • Update Discover site config
  • Update Orion GNU site config
  • By default, use environment modules (tcl/tk) instead of lmod/lua on AWS Ubuntu and Redhat
  • Extend jedi-ufs-all template
  • Update skylab-1.0.0 template
  • Add modulefile templates for qt5 and ecflow
  • Update documentation, especially instructions for building ecflow

Fixes #162 (see https://github.com/climbfuji/spack-stack/runs/6943697862?check_suite_focus=true)

Fixes #211

Fixes #213

Fixes #123

Waiting on JCSDA/spack#106

CI tests all passed except for macos-apple-clang build (for some weird reason, the same test passed before - rerunning now without parallel spack installs). Rerunning macos-apple-clang now manually, check https://github.com/climbfuji/spack-stack/runs/6977275667?check_suite_focus=true for the progress.

@climbfuji climbfuji self-assigned this Jun 17, 2022
@climbfuji climbfuji linked an issue Jun 17, 2022 that may be closed by this pull request
@climbfuji climbfuji linked an issue Jun 18, 2022 that may be closed by this pull request
@climbfuji climbfuji force-pushed the feature/updates_for_rc2 branch from 3c57673 to f0d74e0 Compare June 19, 2022 20:44
@climbfuji climbfuji force-pushed the feature/updates_for_rc2 branch from f0d74e0 to a25219c Compare June 19, 2022 20:54
@climbfuji climbfuji force-pushed the feature/updates_for_rc2 branch 6 times, most recently from fd67ee4 to 9d533ac Compare June 20, 2022 20:20
@climbfuji climbfuji force-pushed the feature/updates_for_rc2 branch from 9d533ac to c08b0f1 Compare June 20, 2022 21:23
@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jun 22, 2022

@kgerheiser CI tests all pass, finally (2934b24) - ready for merging from my side (first spack, then spack-stack).

Update. Looks like my last cleanup of the macOS CI build re-introduced the curl build error. I want to ignore this for the PR, as long as all the others pass, and fix it in a next PR, which has a few minor documentation updates that are not included here.

gmake -j4 2>&1 | tee log.gmake
gmake install 2>&1 | tee log.install

Create modulefile ``/lustre/f2/pdata/esrl/gsd/spack-stack/modulefiles/qt/5.15.3`` from template ``doc/modulefile_templates/qt`` and update ``QT_PATH`` in this file.
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation will be updated and completed over the next week

@climbfuji
Copy link
Copy Markdown
Collaborator Author

All other CI tests passed. This is ready to merge once the spack PR was merged, the submodule pointer updated, and the .gitmodules change reverted.

Comment on lines +293 to +294
## Note: This is unreliable ...
## Speed up installation by building in parallel
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What makes it unreliable? I used this technique myself after seeing it here and it worked fine.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened a few times was that the install step was skipped, as if it ran the query if the jobs are still running faster than they appeared in the ps output. I thought this shouldn't be possible, but simply repeating the same run worked. Could probably be solved by adding a little sleep call in between?

version: [3.0.3]
py-setuptools:
version: [57.4.0]
# Try without
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove that comment as well.

@kgerheiser kgerheiser self-requested a review June 22, 2022 22:04
Comment on lines 172 to 175
pkgconf:
buildable: False
pkg-config:
buildable: False
Copy link
Copy Markdown
Contributor

@kgerheiser kgerheiser Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of them should be buildable. An external pkg-config is generally available on these HPC systems so that's why I say go for that and leave pkgconf as not buildable.

@climbfuji
Copy link
Copy Markdown
Collaborator Author

climbfuji commented Jun 22, 2022 via email

@kgerheiser
Copy link
Copy Markdown
Contributor

macOS does not have a pkgconfig provider built in

@climbfuji
Copy link
Copy Markdown
Collaborator Author

macOS does not have a pkgconfig provider built in

Ok, so let me change it right away then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants