Skip to content

[feature/update_to_spack_v1] Add suffix -openmp to package modules with package variant +openmp; add variants ncview and openmp to neptune-env#1829

Merged
climbfuji merged 9 commits intoJCSDA:feature/update_to_spack_v1from
climbfuji:feature/neptune-devops-noomp-option
Dec 4, 2025
Merged

[feature/update_to_spack_v1] Add suffix -openmp to package modules with package variant +openmp; add variants ncview and openmp to neptune-env#1829
climbfuji merged 9 commits intoJCSDA:feature/update_to_spack_v1from
climbfuji:feature/neptune-devops-noomp-option

Conversation

@climbfuji
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji commented Dec 1, 2025

Description

  1. Add suffix -noopenmp to package modules for esmf, ip, neptune-env when variant ~openmp is used. This includes the special ESMF suffices for MAPL.
  2. Remove unused ESMF suffices for MAPL modules.
  3. Add variants ncview and openmp to the neptune-env virtual package; update the neptune-dev and neptune-ops templates accordingly.
  4. Update submodule pointer for repos/builtin (misc package updates spack-packages#24 and ESMF: Add option to compile without OpenMP spack-packages#25),
  5. Update submodule pointer for spack (install_test.py: append to install-time test log for multiple test phases (#50477) spack#569),

Resulting module li after loading the NEPTUNE environment for no-openmp release build

Currently Loaded Modules:
  1) gcc/13.2.1           13) git/2.43.0            25) sqlite/3.46.0            37) wget/1.24.5          49) nco/5.3.3
  2) stack-gcc/13.2.1     14) hdf5/1.14.5           26) util-linux-uuid/2.41     38) base-env/1.0.0       50) netlib-lapack/3.12.1
  3) glibc/2.34           15) snappy/1.2.1          27) python/3.11.11           39) libyaml/0.2.5        51) p4est/2.8.7
  4) numactl/2.0.18       16) zstd/1.5.7            28) python-venv/1.0          40) py-pyyaml/6.0.2      52) py-f90nml/1.4.3
  5) zlib/1.3.1           17) c-blosc/1.21.6        29) py-pip/25.1.1            41) esmf/8.9.1-noopenmp  53) py-six/1.17.0
  6) pmix/5.0.5           18) netcdf-c/4.9.2        30) py-iniconfig/1.1.1       42) fftw/3.3.10          54) py-python-dateutil/2.8.2
  7) openmpi/5.0.8        19) nccmp/1.9.0.1         31) py-packaging/25.0        43) openblas/0.3.29      55) bacio/2.6.0
  8) stack-openmpi/5.0.8  20) netcdf-fortran/4.6.1  32) py-pluggy/1.5.0          44) ip/5.4.0-noopenmp    56) w3emc/2.11.0
  9) cloc/2.00            21) parallelio/2.6.2      33) py-pytest/8.2.1          45) mct/2.11.0           57) neptune-env/1.5.0-noopenmp
 10) nghttp2/1.65.0       22) pigz/2.8              34) py-setuptools/69.2.0     46) antlr/2.7.7
 11) curl/8.11.1          23) tar/1.35              35) py-setuptools-scm/8.2.1  47) gsl/2.8
 12) cmake/3.31.8         24) gettext/0.23.1        36) py-wheel/0.45.1          48) udunits/2.2.28

Dependencies

None (all submodule PRs listed above already merged)

Issues addressed

Closes #1770
Closes #1803

Applications affected

NEPTUNE

Systems affected

None directly

Testing

  • CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
    • GitHub actions CI tests pass
    • GitHub actions CI tests do not pass (provide explanation)
    • GitHub actions CI tests skipped (provide explanation if necessary)
  • New tests added: List and describe any new tests added to GitHub actions
    • ...
  • Additional testing: Add information on any additional tests conducted
    • ...

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation on readthedocs are included in this PR
    • For site config updates, check in particular doc/source/PreConfiguredSites.rst and doc/source/MaintainersSection.rst
  • All necessary updates to the spack-stack wiki will be made when this PR is merged

@climbfuji climbfuji moved this to In Progress in spack-stack-2.0.x (2025 Q4) Dec 1, 2025
@climbfuji climbfuji self-assigned this Dec 1, 2025
@climbfuji climbfuji changed the title Add suffix -openmp to package modules with package variant +openmp; add variants ncview and openmp to neptune-env [feature/update_to_spack_v1] Add suffix -openmp to package modules with package variant +openmp; add variants ncview and openmp to neptune-env Dec 1, 2025
@climbfuji climbfuji marked this pull request as ready for review December 2, 2025 02:20
…l.yaml: add -noopenmp suffices for esmf, ip, and neptune-env only
@climbfuji
Copy link
Copy Markdown
Collaborator Author

@AlexanderRichert-NOAA @mathomp4 @eap This is now ready with the updated/reversed noopenmp module suffix logic.

@climbfuji
Copy link
Copy Markdown
Collaborator Author

I'll merge this 12/4/2025 with the approval from @rickgrubin-noaa unless there are other reviews/requests for changes. This is so that I can create the PR to update develop from feature/update_to_spack_v1, which needs to be merged on Friday 12/5/2025 to stick to the previously agreed timeline.

@climbfuji climbfuji merged commit 07a83a6 into JCSDA:feature/update_to_spack_v1 Dec 4, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in spack-stack-2.0.x (2025 Q4) Dec 4, 2025
@climbfuji climbfuji deleted the feature/neptune-devops-noomp-option branch December 4, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants