[feature/update_to_spack_v1] Shorten module paths for spack-generated modules and meta-modules#1813
Merged
climbfuji merged 11 commits intoJCSDA:feature/update_to_spack_v1from Nov 12, 2025
Conversation
configs/common/modules_{tcl,lmod}.yaml
…fig_check.py so that tests pass
7ebf60c to
8e4514f
Compare
…and update spack-ext/lib/jcsda-emc/spack-stack/tests/test_setup_meta_modules.py
rickgrubin-noaa
approved these changes
Nov 11, 2025
…eview and testing
…eview and testing
This was referenced Nov 12, 2025
mathomp4
approved these changes
Nov 12, 2025
Collaborator
|
I'm still working on #1810 but once I confirm my latest changes, I'll try and test this next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR shortens the module paths for the modules generated by
spack module [tcl|lmod] refreshandspack stack setup-meta-modules. It does so by implementing a compiler- and MPI-name translation and shortening the path where the modules are generated. This is done in multiple places:While this solution comes with a certain amount of code duplication, I consider it as the best option because any other solution would have required changes to the
spackcode itself. Also, we rarely make changes to these names or add new compilers and MPI providers, thus the maintenance effort is low.While working on this, I realized that the
ecmwf-atlas --> atlastranslation never worked as intended, because it was missing the MPI module dependency. I checked and the spack-generated modules were namedecmwf-atlasbefore this PR was made (at least for tcl modules). I therefore removed this mapping, since the module nameecmwf-atlasapparently worked fine until now.Dependencies
n/a
Issues addressed
Closes #1811
Applications affected
All
Systems affected
All
Testing
Checklist
All necessary updates to the documentation on readthedocs are included in this PRdeferreddoc/source/PreConfiguredSites.rstanddoc/source/MaintainersSection.rstAll necessary updates to the spack-stack wiki will be made when this PR is mergeddeferred