Description

This PR has updates for spack-stack v2 at NAS.

Beyond the updates for the machine itself, I'm also trying to close #1139 and build FMS in two ways with both GFS and GEOS constants.

At the moment, both variants do build, but weirdly I only get a suffix in the modulefiles for GFS → This is no longer true. Was a typo on my end.

The other issue with this is that I'm not sure how to handle the spack-stack unique modules. When I build this, the fms versions are all wonky. To be "safe" only the GEOS important ones should probably default to constants=GEOS FMS, things like jedi-geos-env and geos-gcm-env (which at the moment have internal FMS, but soon will not). I'm not sure how to make these default to constants=GFS. I mean...some did...

install/modulefiles/openmpi/4.1.8/none/none/ufs-weather-model-env/1.0.0
24:    module load fms/2024.02-geos_constants
37:    depends-on fms/2024.02-geos_constants

install/modulefiles/openmpi/4.1.8/none/none/gmao-swell-env/1.0.0
20:    module load fms/2024.02-gfs_constants
44:    depends-on fms/2024.02-gfs_constants

install/modulefiles/openmpi/4.1.8/none/none/ufs-srw-app-env/1.0.0
22:    module load fms/2024.02-geos_constants
47:    depends-on fms/2024.02-geos_constants

install/modulefiles/openmpi/4.1.8/none/none/jedi-fv3-env/1.0.0
19:    module load fms/2024.02-gfs_constants
22:    depends-on fms/2024.02-gfs_constants

install/modulefiles/openmpi/4.1.8/none/none/jedi-ufs-env/1.0.0
21:    module load fms/2024.02-geos_constants
35:    depends-on fms/2024.02-geos_constants

Dependencies

I will need to make a PR to spack-packages for some package updates I need. I'll work with @climbfuji or @AlexanderRichert-NOAA to teach me the right way to do this. I'm not the best at submodules

Issues addressed

Closes #1139

Applications affected

I guess ufs-weather-model-env, ufs-srw-app-env and jedi-ufs-env are now picking up the wrong FMS. Nuts.

Also, I updated geos-gcm-env and jedi-geos-env to [email protected] because we use that now.

Systems affected

NAS directly.

In trying to look at #1139, all other systems?

Testing

• CI: Note whether the automatic tests (GitHub actions tests that run automatically for every commit) pass or not
  • GitHub actions CI tests pass
  • GitHub actions CI tests do not pass (provide explanation)
  • GitHub actions CI tests skipped (provide explanation if necessary)
• New tests added: List and describe any new tests added to GitHub actions
  • ...
• Additional testing: Add information on any additional tests conducted
  • ...

Checklist

• This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
• These changes have been tested on the affected systems and applications.
• All dependency PRs/issues have been resolved and this PR can be merged.
• All necessary updates to the documentation on readthedocs are included in this PR
  • For site config updates, check in particular doc/source/PreConfiguredSites.rst and doc/source/MaintainersSection.rst
• All necessary updates to the spack-stack wiki will be made when this PR is merged