fetch_cargo_deps.py: ensure CARGO_HOME is used#1804
Merged
climbfuji merged 1 commit intofeature/update_to_spack_v1from Oct 30, 2025
Merged
fetch_cargo_deps.py: ensure CARGO_HOME is used#1804climbfuji merged 1 commit intofeature/update_to_spack_v1from
climbfuji merged 1 commit intofeature/update_to_spack_v1from
Conversation
climbfuji
reviewed
Oct 29, 2025
| cargo_exe = Executable(cargo_wrapper) | ||
|
|
||
| env = EnvironmentModifications() | ||
| env.set("CARGO_HOME", cargo_home) |
Collaborator
There was a problem hiding this comment.
I am surprised this is needed, because of lines 44-47 above
cargo_home = os.getenv("CARGO_HOME")
if not cargo_home:
raise SpackError("CARGO_HOME must be set")
Collaborator
Author
There was a problem hiding this comment.
Indeed. It seems that maybe there's something about the Executable logic that's not automatically propagating it? 🤷
Collaborator
There was a problem hiding this comment.
I noticed something similar with the wrapper script, #!/usr/bin/env bash doesn't work anymore. I had to change it to just #!/bin/bash in PR #1798
climbfuji
approved these changes
Oct 30, 2025
AlexanderRichert-NOAA
requested review from
Hang-Lei-NOAA,
RatkoVasic-NOAA,
rickgrubin and
rickgrubin-noaa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that CARGO_HOME is used (rather than the default of ~/.cargo) when fetching cargo deps, and also gets rid of the llnl.* deprecation warning for fetch_cargo_deps.py.
Dependencies
none
Issues addressed
none
Applications affected
most
Systems affected
all
Testing
Checklist