Skip to content

Acorn spack-stack v2 updates#1791

Merged
AlexanderRichert-NOAA merged 18 commits intoJCSDA:feature/update_to_spack_v1from
AlexanderRichert-NOAA:acorn_spackstackv2
Oct 22, 2025
Merged

Acorn spack-stack v2 updates#1791
AlexanderRichert-NOAA merged 18 commits intoJCSDA:feature/update_to_spack_v1from
AlexanderRichert-NOAA:acorn_spackstackv2

Conversation

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Collaborator

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Oct 9, 2025 •
edited
Loading

Description

This PR:

  • updates the site config for Acorn for spack-stack v2/spack v1 -- it only supports oneAPI 2024.2.1
  • adds an experimental deploy.py script for YAML-configured push-button installations on Acorn
  • updates fetch_cargo_deps.py to first try to use a given spec's associated rust installation, as well as add cargo_home/bin/ to PATH when running cargo because apparently at least some versions need that in order to find rustc.

Dependencies

none

Issues addressed

Related to #1772
Related to #1604

Applications affected

UFS WM, GW, misc. EMC

Systems affected

Acorn

Testing

  • Additional testing:
    • deploy.py tested on Acorn

Checklist

  • This PR addresses one issue/problem/enhancement or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.
  • All necessary updates to the documentation on readthedocs are included in this PR
    • For site config updates, check in particular doc/source/PreConfiguredSites.rst and doc/source/MaintainersSection.rst
  • All necessary updates to the spack-stack wiki will be made when this PR is merged

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review October 9, 2025 18:03
@climbfuji
Copy link
Copy Markdown
Collaborator

climbfuji commented Oct 9, 2025

I'll wait for the CI tests to pass, thanks for the chained env bug fixes.

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Collaborator Author

AlexanderRichert-NOAA commented Oct 10, 2025

A couple final tweaks. Any future updates will be a separate PR.

climbfuji
climbfuji reviewed Oct 10, 2025
View reviewed changes
Hang-Lei-NOAA
Hang-Lei-NOAA reviewed Oct 21, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@Hang-Lei-NOAA Hang-Lei-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It takes a long time to read the copilot review. But its concerns are all about the impact on other platforms, after a carefully reading. Copilot is trying to optimize it to a universal frame not considering the specific settings for acorn.
I am going to try it on Acorn.

@AlexanderRichert-NOAA AlexanderRichert-NOAA merged commit ab957f9 into JCSDA:feature/update_to_spack_v1 Oct 22, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@climbfuji climbfuji climbfuji approved these changes

@Hang-Lei-NOAA Hang-Lei-NOAA Hang-Lei-NOAA approved these changes

@eap eap Awaiting requested review from eap

@RatkoVasic-NOAA RatkoVasic-NOAA Awaiting requested review from RatkoVasic-NOAA

@rickgrubin rickgrubin Awaiting requested review from rickgrubin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AlexanderRichert-NOAA @climbfuji @Hang-Lei-NOAA