Skip to content

Add multiple UFS WM tests to automated build / test#1629

Merged
climbfuji merged 57 commits intoJCSDA:developfrom
rickgrubin-noaa:multiple_ufs_tests
May 12, 2025
Merged

Add multiple UFS WM tests to automated build / test#1629
climbfuji merged 57 commits intoJCSDA:developfrom
rickgrubin-noaa:multiple_ufs_tests

Conversation

@rickgrubin-noaa
Copy link
Copy Markdown
Collaborator

Summary

Two primary changes:

  • add a test configuration file (rt.conf) for multiple UFS WM tests
    • option to override the UFS WM default setting for variable dprefix (where test results are written)
  • default compiler for orion is now oneAPI
    • MSU sysadmins removed the Intel classic compiler+MPI modules / will not reinstall them

Also:

  • update a setting for WORK_DIR / `$(dirname $0)

  • ability to override default settings for SPACK_STACK_URL and SPACK_STACK_BRANCH

  • fix setting of a return code

  • updated hercules and orion packages.yaml to build against externally provided Qt

  • removed entry for oneAPI compiler module for hercules / orion packages_oneapi.yaml files. Its presence led to this issue.

Testing

End-to-end build / test (via command line) of a spack-stack branch based on the develop branch. UFS WM tests completed successfully.

Applications affected

Did not test util/show_duplicate_packages.py per this issue.

Systems affected

  • orion
  • hercules

Dependencies

None, but could wait for a fix to Concretization of spack-stack@develop produces duplicate packages #1628.

Issue(s) addressed

Orion, spack-stack-1.9.1, oneapi environment points to ifx instead of ifort #1627

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

Remove spurious tab
@rickgrubin-noaa rickgrubin-noaa self-assigned this May 5, 2025
@rickgrubin-noaa rickgrubin-noaa marked this pull request as ready for review May 7, 2025 16:30
Copy link
Copy Markdown
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Collaborator

This is awesome, this is a great step forward. I forget, in terms of pointing UWM to the test installation, are you still using your UWM fork?

@rickgrubin-tomorrow
Copy link
Copy Markdown

@AlexanderRichert-NOAA it was tested against @RatkoVasic-NOAA's branch (ss-191) which contains the necessary changes for a variety of components to build and run against [email protected]. That work is a big step forward and close to being finished / merged.

For testing -- and the reason that SPACK_STACK_URL and SPACK_STACK_BRANCH can be set outside of the scripts -- I kept my forked spack-stack repo current with spack-stack@develop and built against that for end-to-end testing.

@climbfuji
Copy link
Copy Markdown
Collaborator

@AlexanderRichert-NOAA Ok to update and merge?

@AlexanderRichert-NOAA
Copy link
Copy Markdown
Collaborator

Yes looks good thanks

@climbfuji climbfuji enabled auto-merge (squash) May 12, 2025 16:31
@climbfuji climbfuji merged commit d8d7614 into JCSDA:develop May 12, 2025
8 checks passed
@rickgrubin-noaa rickgrubin-noaa deleted the multiple_ufs_tests branch June 25, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants