Remove parallel-netcdf dependency except for jedi-mpas-env/unified-dev/skylab-dev#1621
Merged
climbfuji merged 4 commits intoJCSDA:developfrom Apr 30, 2025
Conversation
… and enable variant +pnetcdf for parallelio in jedi-mpas-env
…environment templates unified-dev, skylab-dev, neptune-dev
…icly available in .github/workflows/ubuntu-ci-x86_64-gnu.yaml
AlexanderRichert-NOAA
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
parallel-netcdfdependency frombase-env. Instead, add it tojedi-mpas-envand enable the variant+pnetcdfforparallelioinjedi-mpas-env(the default for this variant is~pnetcdf).This means that environments using template
neptune-devconcretize withoutparallel-netcdf, but any template that includesjedi-mpas-env(e.g.unified-dev,skylab-dev) concretize withparallel-netcdf.I added
neptune-devas an additional template to the Ubuntu GNU runner, but had to disable thexnrlvariant since this package isn't publicly available. Forneptune-dev, parallel-netcdf is removed, forunified-devandskylab-dev, it is included as before.Testing
I tested this on my laptop and I also confirmed that the CI builds behave as expected (see https://github.com/JCSDA/spack-stack/actions/runs/14740976173/job/41378625127?pr=1621)
Applications affected
None - NEPTUNE doesn't use
parallel-netcdf, and the other environments in use will still have it.Systems affected
None
Dependencies
None
Issue(s) addressed
Closes #1613
Checklist
All dependency PRs/issues have been resolved and this PR can be merged.