Skip to content

Update compiler / packages_oneapi configs and instructions for preconfigured sites | orion and hercules#1606

Merged
climbfuji merged 39 commits intoJCSDA:developfrom
rickgrubin-noaa:orion_hercules_module_load
Apr 16, 2025
Merged

Update compiler / packages_oneapi configs and instructions for preconfigured sites | orion and hercules#1606
climbfuji merged 39 commits intoJCSDA:developfrom
rickgrubin-noaa:orion_hercules_module_load

Conversation

@rickgrubin-noaa
Copy link
Copy Markdown
Collaborator

Summary

As described in #1538:

Using the spack-managed-x86-64_v3/v1.0 module on orion & hercules is problematic because the "pushenv" executed in that modulefile undoes spack-stack's changes to $MODULEPATH, making our stack-oneapi and subsequent modules unable to load.

Modifying:

/apps/contrib/spack-stack/spack-stack-1.9.0/envs/ue-oneapi-2024.2.1/install/modulefiles/oneapi/2024.2.1/stack-intel-oneapi-mpi/2021.13.lua

and

/apps/contrib/spack-stack/spack-stack-1.9.0/envs/ue-oneapi-2024.2.1/install/modulefiles/Core/stack-oneapi/2024.2.1.lua
to prepend $MODULEPATH using the same set of paths that would have come from spack-managed-x86-64_v3/v1.0 solves the issue, but requires after-the-fact intervention.

spack-managed-x86-64_v3/v1.0 does not need to be specified as a required module in both compilers.yaml and packages_oneapi.yaml for the stack to build. It can be loaded by a stack user prior to loading spack-stack and achieve the desired result.

Testing

  • built spack-stack @ release/1.9.1 on hercules and orion
  • ran UFS WM regression test control_c48 to demonstrate functionality
    • UFS WM modulefiles below were modified to appropriately set MODULEPATH
      • modulefiles/ufs_hercules.intel.lua
      • modulefiles/ufs_orion.intel.lua

Applications affected

On hercules and orion, any application that builds upon spack-stack @ release/1.9.1

Systems affected

hercules and orion

Dependencies

n/a

Issue(s) addressed

Fixes #1538

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

Remove spurious tab

.. code-block:: console
module purge
module load spack-managed-x86-64_v3/v1.0
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the wiki also need to be updated (i.e. do we need to load spack-managed-x86-64_v3/v1.0 before the spack-stack module use & module load commands)?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wiki does need to be updated -- was waiting on the PR approval so as to update only with correct info -- will update it this morning.

@climbfuji
Copy link
Copy Markdown
Collaborator

Unit tests are failing because the Ubuntu 20 runner is now deprecated. I will fix this when I update spack from the authoritative repo.

@climbfuji climbfuji merged commit c04874c into JCSDA:develop Apr 16, 2025
8 of 10 checks passed
@rickgrubin-noaa rickgrubin-noaa deleted the orion_hercules_module_load branch October 2, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Orion & Hercules module config issue for spack-stack-1.9.0

3 participants