show_duplicate_packages.py: use spack.lock instead of 'spack concretize' output#1601
Merged
climbfuji merged 7 commits intoJCSDA:developfrom Apr 30, 2025
Merged
Conversation
Collaborator
Author
|
This is good to go assuming the remaining CIs succeed |
climbfuji
reviewed
Apr 30, 2025
climbfuji
approved these changes
Apr 30, 2025
5 tasks
climbfuji
added a commit
that referenced
this pull request
Apr 30, 2025
PR #1601 updated show_duplicate_packages.py, but many places were missed (documentation and actual use in scripts).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates show_duplicate_packages.py to use spack.lock to detect duplicates rather than
spack concretizestdout. It is safer (especially if an environment has been concretized in multiple steps), it simplifies the code, and it's cleaner. It removes the -d option (it now only shows duplicates), and the -c option (which at this point we don't really have any use for because we're doing one-compiler environments).Testing
Tested on personal machine (+updating util tests).
Applications affected
n/a
Systems affected
all
Dependencies
none
Issue(s) addressed
none
Checklist