Skip to content

Remove discover-scu16 configs#1576

Merged
climbfuji merged 2 commits intoJCSDA:developfrom
ashley314:feature/remove_discoverscu16
Mar 26, 2025
Merged

Remove discover-scu16 configs#1576
climbfuji merged 2 commits intoJCSDA:developfrom
ashley314:feature/remove_discoverscu16

Conversation

@ashley314
Copy link
Copy Markdown
Collaborator

@ashley314 ashley314 commented Mar 25, 2025 •
edited
Loading

Summary

Removing discover-scu16 configuration in spack-stack.

Testing

NA

Applications affected

NA

Systems affected

Discover-scu16 will no longer be used.

Dependencies

None

Issue(s) addressed

#1569

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@ashley314 ashley314 added the INFRA JEDI Infrastructure label Mar 25, 2025
@ashley314 ashley314 self-assigned this Mar 25, 2025
@ashley314 ashley314 marked this pull request as ready for review March 25, 2025 15:41
@ashley314 ashley314 requested review from climbfuji, eap and stiggy87 March 25, 2025 15:41
@ashley314 ashley314 linked an issue Mar 25, 2025 that may be closed by this pull request
Remove discover-scu16 configuration #1569
Closed
eap
eap approved these changes Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@eap eap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove discover SCU16 references from //doc/source/PreConfiguredSites.rst

@ashley314
Copy link
Copy Markdown
Collaborator Author

ashley314 commented Mar 25, 2025

Should we also remove discover SCU16 references from //doc/source/PreConfiguredSites.rst

Ah good call!

climbfuji
climbfuji approved these changes Mar 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove references to it in the wiki (spack-stack-1.9 section, it's still valid in the older sections)

@ashley314
Copy link
Copy Markdown
Collaborator Author

ashley314 commented Mar 25, 2025

Please also remove references to it in the wiki (spack-stack-1.9 section, it's still valid in the older sections)

I removed it in 1.9 when updating the wiki for discover-scu17. So the wiki is good unless I am missing a section other than https://github.com/JCSDA/spack-stack/wiki/spack%E2%80%90stack%E2%80%901.9.1-release-documentation

@climbfuji
Copy link
Copy Markdown
Collaborator

climbfuji commented Mar 25, 2025

Please also remove references to it in the wiki (spack-stack-1.9 section, it's still valid in the older sections)

I removed it in 1.9 when updating the wiki for discover-scu17. So the wiki is good unless I am missing a section other than https://github.com/JCSDA/spack-stack/wiki/spack%E2%80%90stack%E2%80%901.9.1-release-documentation

Great, thanks!

@climbfuji climbfuji merged commit e0bb93d into JCSDA:develop Mar 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@climbfuji climbfuji climbfuji approved these changes

@eap eap eap approved these changes

@stiggy87 stiggy87 Awaiting requested review from stiggy87

Assignees

@ashley314 ashley314

Labels

INFRA JEDI Infrastructure

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove discover-scu16 configuration

3 participants

@ashley314 @climbfuji @eap